From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E07F268DB5 for ; Thu, 10 Mar 2022 14:41:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D4DBD1AFF1 for ; Thu, 10 Mar 2022 14:41:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9FB0A1AFE6 for ; Thu, 10 Mar 2022 14:41:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7233B463DB for ; Thu, 10 Mar 2022 14:41:33 +0100 (CET) Message-ID: <44bc53c3-8bbc-f39d-e33b-2ae916aeeff3@proxmox.com> Date: Thu, 10 Mar 2022 14:41:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: Proxmox Backup Server development discussion , Stefan Sterz References: <20220309135343.2052890-1-s.sterz@proxmox.com> From: Dylan Whyte In-Reply-To: <20220309135343.2052890-1-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.363 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, wikipedia.org, proxmox.com, ietf.org, pmt.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup] pbs-tape/docs/api: fix miscellaneous typos X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2022 13:41:34 -0000 Hi, Thanks for the patch. Just some small suggestions, while you're at it ;) Reviewed-by: Dylan Whyte Best regards, Dylan On 3/9/22 14:53, Stefan Sterz wrote: > Signed-off-by: Stefan Sterz > --- > docs/epilog.rst | 2 +- > docs/terminology.rst | 2 +- > pbs-tape/src/bin/pmt.rs | 2 +- > src/api2/admin/datastore.rs | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/docs/epilog.rst b/docs/epilog.rst > index 54e21a03..ed6a8800 100644 > --- a/docs/epilog.rst > +++ b/docs/epilog.rst > @@ -35,7 +35,7 @@ > .. _ZFS: https://en.wikipedia.org/wiki/ZFS > .. _Proxmox VE: https://pve.proxmox.com > > -.. _RFC3399: https://tools.ietf.org/html/rfc3339 > +.. _RFC3339: https://tools.ietf.org/html/rfc3339 > .. _UTC: https://en.wikipedia.org/wiki/Coordinated_Universal_Time > .. _ISO Week date: https://en.wikipedia.org/wiki/ISO_week_date > > diff --git a/docs/terminology.rst b/docs/terminology.rst > index dcce117b..c5551818 100644 > --- a/docs/terminology.rst > +++ b/docs/terminology.rst > @@ -116,7 +116,7 @@ uniquely identifies a specific backup within a datastore. > vm/104/2019-10-09T08:01:06Z > host/elsa/2019-11-08T09:48:14Z > > -As you can see, the time format is RFC3399_ with Coordinated > +As you can see, the time format is RFC3339_ with Coordinated > Universal Time (UTC_, identified by the trailing *Z*). > > > diff --git a/pbs-tape/src/bin/pmt.rs b/pbs-tape/src/bin/pmt.rs > index 8f61c322..e7080bd8 100644 > --- a/pbs-tape/src/bin/pmt.rs > +++ b/pbs-tape/src/bin/pmt.rs > @@ -1,7 +1,7 @@ > /// Control magnetic tape drive operation > /// > /// This is a Rust implementation, using the Proxmox userspace tape > -/// driver. This is meant as replacement fot the 'mt' command line > +/// driver. This is meant as replacement for the 'mt' command line s/as replacement/as a replacement/ > /// tool. > /// > /// Features: > diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs > index 263ea96f..c0a87c1a 100644 > --- a/src/api2/admin/datastore.rs > +++ b/src/api2/admin/datastore.rs > @@ -273,7 +273,7 @@ pub fn delete_group( > check_priv_or_backup_owner(&datastore, &group, &auth_id, PRIV_DATASTORE_MODIFY)?; > > if !datastore.remove_backup_group(&group)? { > - bail!("did not delete whole group because of protected snapthots"); > + bail!("did not delete whole group because of protected snapshots"); I would reword to: "group only partially deleted due to protected snapshots" > } > > Ok(Value::Null)