From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6CEA396475 for ; Mon, 15 Apr 2024 18:27:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4C2ECEF06 for ; Mon, 15 Apr 2024 18:27:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 15 Apr 2024 18:27:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0951644CBD for ; Mon, 15 Apr 2024 18:27:16 +0200 (CEST) Message-ID: <43d400b0-232b-495a-9d21-de6a0d23c32d@proxmox.com> Date: Mon, 15 Apr 2024 18:27:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Hannes Laimer References: <20240409110012.166472-1-h.laimer@proxmox.com> <20240409110012.166472-9-h.laimer@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20240409110012.166472-9-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 08/24] api2: disks list: add only-unused flag X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Apr 2024 16:27:17 -0000 a few comments inline On 4/9/24 12:59, Hannes Laimer wrote: > ... used by the partition selector for removable datastore creation. > > Signed-off-by: Hannes Laimer > --- > src/api2/node/disks/mod.rs | 8 +++++ > src/tools/disks/mod.rs | 67 +++++++++++++++++++++++++++++++++----- > 2 files changed, 66 insertions(+), 9 deletions(-) > > diff --git a/src/api2/node/disks/mod.rs b/src/api2/node/disks/mod.rs > index 711dae7b..bd251dab 100644 > --- a/src/api2/node/disks/mod.rs > +++ b/src/api2/node/disks/mod.rs > @@ -41,6 +41,12 @@ pub mod zfs; > optional: true, > default: false, > }, > + "only-unused": { > + description: "Only list partitions not used for removable datastores or mounted directories.", Since the parameter before this one is called `include-partitions`, might be worth to keep a similar naming scheme and call this `exclude-used` and as description something like `Exclude partitions already used for removable datastores or mounted directories.` This would also help improve the naming of the `only_not_in_use` variables and methods (imho). > + type: bool, > + optional: true, > + default: false, > + }, > "usage-type": { > type: DiskUsageType, > optional: true, > @@ -62,6 +68,7 @@ pub mod zfs; > pub fn list_disks( > skipsmart: bool, > include_partitions: bool, > + only_unused: bool, with above suggestion, this is renamed to `exclude_used` ... > usage_type: Option, > ) -> Result, Error> { > let mut list = Vec::new(); > @@ -69,6 +76,7 @@ pub fn list_disks( > for (_, info) in DiskUsageQuery::new() > .smart(!skipsmart) > .partitions(include_partitions) > + .only_not_in_use(only_unused) ... `exclude_used(exclude_used)` > .query()? > { > if let Some(ref usage_type) = usage_type { > diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs > index eaf016df..81184eb6 100644 > --- a/src/tools/disks/mod.rs > +++ b/src/tools/disks/mod.rs > @@ -20,6 +20,7 @@ use proxmox_rest_server::WorkerTask; > use proxmox_schema::api; > use proxmox_sys::linux::procfs::{mountinfo::Device, MountInfo}; > use proxmox_sys::task_log; > +use serde_json::Value; > > use pbs_api_types::{BLOCKDEVICE_DISK_AND_PARTITION_NAME_REGEX, BLOCKDEVICE_NAME_REGEX}; > > @@ -32,6 +33,7 @@ pub use zpool_list::*; > mod lvm; > pub use lvm::*; > mod smart; > +use crate::api2::node::disks::directory::list_datastore_mounts; > pub use smart::*; > > lazy_static::lazy_static! { > @@ -828,6 +830,7 @@ fn scan_partitions( > pub struct DiskUsageQuery { > smart: bool, > partitions: bool, > + only_not_in_use: bool, > } > > impl DiskUsageQuery { > @@ -835,6 +838,7 @@ impl DiskUsageQuery { > Self { > smart: true, > partitions: false, > + only_not_in_use: false, ... `exclude_used` > } > } > > @@ -848,12 +852,22 @@ impl DiskUsageQuery { > self > } > > + pub fn only_not_in_use(&mut self, only_not_in_use: bool) -> &mut Self { > + self.only_not_in_use = only_not_in_use; ... ditto, not going to comment all of them > + self > + } > + > pub fn query(&self) -> Result, Error> { > - get_disks(None, !self.smart, self.partitions) > + get_disks(None, !self.smart, self.partitions, self.only_not_in_use) > } > > pub fn find(&self, disk: &str) -> Result { > - let mut map = get_disks(Some(vec![disk.to_string()]), !self.smart, self.partitions)?; > + let mut map = get_disks( > + Some(vec![disk.to_string()]), > + !self.smart, > + self.partitions, > + self.only_not_in_use, > + )?; > if let Some(info) = map.remove(disk) { > Ok(info) > } else { > @@ -862,7 +876,12 @@ impl DiskUsageQuery { > } > > pub fn find_all(&self, disks: Vec) -> Result, Error> { > - get_disks(Some(disks), !self.smart, self.partitions) > + get_disks( > + Some(disks), > + !self.smart, > + self.partitions, > + self.only_not_in_use, > + ) > } > } > > @@ -935,6 +954,8 @@ fn get_disks( > no_smart: bool, > // include partitions > include_partitions: bool, > + // skip partitions which are in use > + only_not_in_use: bool, > ) -> Result, Error> { > let disk_manager = DiskManage::new(); > > @@ -952,6 +973,30 @@ fn get_disks( > > // fixme: ceph journals/volumes > > + let uuids_in_use = if only_not_in_use && include_partitions { > + let (config, _digest) = pbs_config::datastore::config()?; > + > + let uuids_from_datastores: Vec = config > + .sections > + .iter() > + .filter_map(|(_, (_, data))| { > + data.as_object() > + .and_then(|cfg| cfg.get("backing-device")) > + .and_then(Value::as_str) > + .map(String::from) > + }) > + .collect(); > + > + let uuids_from_mounts: Vec = list_datastore_mounts()? > + .into_iter() > + .filter_map(|mount| mount.device.split('/').last().map(String::from)) > + .collect(); > + > + [&uuids_from_datastores[..], &uuids_from_mounts[..]].concat() > + } else { > + Vec::new() > + }; > + > let mut result = HashMap::new(); > > for item in proxmox_sys::fs::scan_subdir(libc::AT_FDCWD, "/sys/block", &BLOCKDEVICE_NAME_REGEX)? > @@ -1024,12 +1069,16 @@ fn get_disks( > > let partitions: Option> = if include_partitions { > disk.partitions().map_or(None, |parts| { > - Some(get_partitions_info( > - parts, > - &lvm_devices, > - &zfs_devices, > - &file_system_devices, > - )) > + let infos = > + get_partitions_info(parts, &lvm_devices, &zfs_devices, &file_system_devices) > + .into_iter() > + .filter(|part| { > + part.uuid > + .as_ref() > + .map_or(true, |u| !uuids_in_use.contains(u)) > + }) > + .collect(); > + Some(infos) > }) > } else { > None