From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3A10A1FF15C for ; Wed, 7 Aug 2024 16:48:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 854FE9527; Wed, 7 Aug 2024 16:48:51 +0200 (CEST) Message-ID: <43893cf8-c877-4805-9684-abfd5c9bf6d9@proxmox.com> Date: Wed, 7 Aug 2024 16:48:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion , Lukas Wagner , Maximiliano Sandoval References: <20240807103222.219740-1-m.sandoval@proxmox.com> <20240807103222.219740-4-m.sandoval@proxmox.com> <64f12f74-8b2a-4cad-9c60-39087343b9f0@proxmox.com> Content-Language: en-GB From: Thomas Lamprecht In-Reply-To: <64f12f74-8b2a-4cad-9c60-39087343b9f0@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.676 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_ABUSE_SURBL 1.25 Contains an URL listed in the ABUSE SURBL blocklist [tasks.rs] URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, tasks.rs, ldap.rs] Subject: Re: [pbs-devel] [PATCH backup 4/5] fix typos in strings X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 07/08/2024 12:52, Lukas Wagner wrote: > On 2024-08-07 12:32, Maximiliano Sandoval wrote: >> Signed-off-by: Maximiliano Sandoval >> --- >> docs/lto-barcode/page-calibration.js | 8 ++++---- >> pbs-api-types/src/ldap.rs | 2 +- >> src/api2/node/tasks.rs | 2 +- >> 3 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/docs/lto-barcode/page-calibration.js b/docs/lto-barcode/page-calibration.js >> index 3c7fed82..54512a9f 100644 >> --- a/docs/lto-barcode/page-calibration.js >> +++ b/docs/lto-barcode/page-calibration.js >> @@ -108,7 +108,7 @@ Ext.define('PageCalibration', { >> xtype: 'numberfield', >> value: 'a4', >> name: 's_x', >> - fieldLabel: 'Meassured Start Offset Sx (mm)', >> + fieldLabel: 'Measured Start Offset Sx (mm)', > > I wonder, shouldn't these use gettext? > The LTO barcode label tool [0] has no gettext infra and is currently also not considered when extracting texts for the i18n repo. In that small app the gettext function is defined as identity function [1] just to avoid that the widget-toolkit breaks. While we could naturally add i18n support, the LTO barcode label app is a 1) rather niche tool and 2) not really complex, so it might be a bit overkill, at least without users requesting i18n support there. [0]: https://pbs.proxmox.com/docs/lto-barcode/index.html [1]: https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=docs/lto-barcode/lto-barcode.js;h=2aeaba1b6084c5baf178a8cf5445e6c728dae719;hb=ab8e84498d9cba8be280ebbeb2ffe9daf6cc439a#l1 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel