From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dietmar@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 291EE6C8B0 for <pbs-devel@lists.proxmox.com>; Tue, 30 Mar 2021 09:10:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 177621BD60 for <pbs-devel@lists.proxmox.com>; Tue, 30 Mar 2021 09:10:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 057431BD50 for <pbs-devel@lists.proxmox.com>; Tue, 30 Mar 2021 09:10:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B7BD141E71 for <pbs-devel@lists.proxmox.com>; Tue, 30 Mar 2021 09:10:52 +0200 (CEST) Date: Tue, 30 Mar 2021 09:10:50 +0200 (CEST) From: Dietmar Maurer <dietmar@proxmox.com> To: Wolfgang Bumiller <w.bumiller@proxmox.com>, Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> Message-ID: <435678602.1487.1617088250415@webmail.proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.5-Rev5 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.113 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH pxar] encoder: flush after writing last entry X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 30 Mar 2021 07:10:54 -0000 > After an off-list talk with Dominik we concluded that keeping it for `Owned` > writers is the safer approach for the simple reason that in *async* code (eg. > tokio's async BufWriter equivalent) you *do* need to flush buffered writers. > > This is probably because there's no `AsyncDrop` and there's no guarantee that > the future's `Drop` handler is called in a place where it is safe to call > tokio's `block_in_place` (after all it panics when it is outside a tokio RT > thread, *including* being inside a `runtime.block_on()` called from outside > a tokio RT thread). > > So yeah, let's not revert this, but limit it to `EncoderOutput::Owned`. But Flushing at every sub-dir makes no real sense. You only need to flush once when you are finished writing the pxar (for the top level dir)?