From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A27F4704F7 for ; Fri, 2 Apr 2021 14:07:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A0748E7C1 for ; Fri, 2 Apr 2021 14:07:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EFE97E7B2 for ; Fri, 2 Apr 2021 14:07:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B95E2435DE for ; Fri, 2 Apr 2021 14:07:10 +0200 (CEST) Message-ID: <4354baba-4e07-270b-5341-24d7170f0bed@proxmox.com> Date: Fri, 2 Apr 2021 14:07:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210401141123.12964-1-d.csapak@proxmox.com> <20210401141123.12964-2-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210401141123.12964-2-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.043 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [compression.rs, tools.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 1/5] tools: add compression module X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2021 12:07:11 -0000 On 01.04.21 16:11, Dominik Csapak wrote: > only contains a basic enum for the different compresssion methods > > Signed-off-by: Dominik Csapak > --- > src/tools.rs | 1 + > src/tools/compression.rs | 37 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 38 insertions(+) > create mode 100644 src/tools/compression.rs > > diff --git a/src/tools.rs b/src/tools.rs > index 7e3bff7b..cd1415ec 100644 > --- a/src/tools.rs > +++ b/src/tools.rs > @@ -22,6 +22,7 @@ pub mod apt; > pub mod async_io; > pub mod borrow; > pub mod cert; > +pub mod compression; > pub mod daemon; > pub mod disks; > pub mod format; > diff --git a/src/tools/compression.rs b/src/tools/compression.rs > new file mode 100644 > index 00000000..fe15e8fc > --- /dev/null > +++ b/src/tools/compression.rs > @@ -0,0 +1,37 @@ > +use anyhow::{bail, Error}; > +use hyper::header; > + > +/// Possible Compression Methods, order determines preference (later is preferred) > +#[derive(Eq, Ord, PartialEq, PartialOrd, Debug)] > +pub enum CompressionMethod { > + Deflate, > + Gzip, > + Brotli, > +} > + > +impl CompressionMethod { > + pub fn content_encoding(&self) -> header::HeaderValue { > + header::HeaderValue::from_static(self.extension()) > + } > + > + pub fn extension(&self) -> &'static str { > + match *self { > + CompressionMethod::Brotli => "br", > + CompressionMethod::Gzip => "gzip", > + CompressionMethod::Deflate => "deflate", I'd for now comment those out, as else we have a Some(_) in most match arms meaning that when we actually implement those there's a higher chance that we forget to add the match to such an arm and rust won't notice due to the "catch all". > + } > + } > +} > + > +impl std::str::FromStr for CompressionMethod { > + type Err = Error; > + > + fn from_str(s: &str) -> Result { > + match s { > + "br" => Ok(CompressionMethod::Brotli), > + "gzip" => Ok(CompressionMethod::Brotli), above should be CompressionMethod::Gzip > + "deflate" => Ok(CompressionMethod::Deflate), > + _ => bail!("unknown compression format"), > + } > + } > +} >