From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6E56F1FF15C for ; Wed, 27 Nov 2024 10:03:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E928E1281A; Wed, 27 Nov 2024 10:03:29 +0100 (CET) Message-ID: <433bb804-e861-4201-a802-17c709ecaff1@proxmox.com> Date: Wed, 27 Nov 2024 10:03:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20241126165126.167497-1-h.laimer@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] api: directory: use relative path when creating removable datastore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 11/27/24 09:58, Thomas Lamprecht wrote: > Can you please add a comment message for this with some rationale, e.g., > why the old value was assembled that way, if there was any reasoning back > then, simple mistakes naturally happen too to everybody, and/or why this > is now the correct way. > > You can also write it as reply and I amend the patch or send a v2, > whatever you prefer. > In an earlier version of this series the datastore path was absolute for removable datastores. This is a leftover I missed when changing that. > Am 26.11.24 um 17:51 schrieb Hannes Laimer: >> Reported-by: Markus Frank >> Fixes: 94a068e31 ("api: node: allow creation of removable datastore through directory endpoint") >> Signed-off-by: Hannes Laimer >> --- >> src/api2/node/disks/directory.rs | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/api2/node/disks/directory.rs b/src/api2/node/disks/directory.rs >> index 2f7cc7a27..6a76dd5a7 100644 >> --- a/src/api2/node/disks/directory.rs >> +++ b/src/api2/node/disks/directory.rs >> @@ -237,7 +237,7 @@ pub fn create_datastore_disk( >> let lock = pbs_config::datastore::lock_config()?; >> let datastore: DataStoreConfig = if removable_datastore { >> serde_json::from_value( >> - json!({ "name": name, "path": format!("/{name}"), "backing-device": uuid }), >> + json!({ "name": name, "path": name, "backing-device": uuid }), >> )? >> } else { >> serde_json::from_value(json!({ "name": name, "path": mount_point }))? > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel