From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5EDBA6468E for ; Mon, 20 Jul 2020 12:01:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 440D2C45A for ; Mon, 20 Jul 2020 12:00:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BE0DAC44F for ; Mon, 20 Jul 2020 12:00:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6E05543263 for ; Mon, 20 Jul 2020 12:00:30 +0200 (CEST) To: Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20200720082213.1246052-1-f.gruenbichler@proxmox.com> From: Thomas Lamprecht Message-ID: <4320abd3-c656-b7e0-c70d-71673a804322@proxmox.com> Date: Mon, 20 Jul 2020 12:00:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:79.0) Gecko/20100101 Thunderbird/79.0 MIME-Version: 1.0 In-Reply-To: <20200720082213.1246052-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.010 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 1/2] manifest: revert canonicalization to old behaviour X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2020 10:01:01 -0000 On 20.07.20 10:22, Fabian Gr=C3=BCnbichler wrote: > JSON keys MUST be quoted. this is a one-time break in signature > validation for backups created with the broken canonicalization code. > QEMU backups are not affected, as libproxmox-backup-qemu never linked > the broken versions. >=20 > Signed-off-by: Fabian Gr=C3=BCnbichler > --- > Note: after this has been applied and proxmox-backup has been bumped, > libproxmox-backup-qemu needs to be be re-built with the new code and > bumped for restore to work again. >=20 > src/backup/manifest.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > applied series, thanks!