From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 79470617DB for ; Thu, 17 Dec 2020 17:12:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 685DA28AC5 for ; Thu, 17 Dec 2020 17:12:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5143428AB8 for ; Thu, 17 Dec 2020 17:12:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1D4B445259 for ; Thu, 17 Dec 2020 17:12:24 +0100 (CET) To: Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20201217142745.661843-1-f.gruenbichler@proxmox.com> From: Thomas Lamprecht Message-ID: <428fc59d-c710-b129-1931-efcea562adbf@proxmox.com> Date: Thu, 17 Dec 2020 17:12:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20201217142745.661843-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.065 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [RFC proxmox-backup 1/3] acl: add docs and adapt visibility X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2020 16:12:55 -0000 On 17/12/2020 15:27, Fabian Grünbichler wrote: > document all public things, add some doc links and make some > previously-public things only available for test cases or within the > crate: > > previously public, now private: > - AclTreeNode::extract_user_roles (we have extract_roles()) > - AclTreeNode::extract_group_roles (same) > - AclTreeNode::delete_group_role (exists on AclTree) > - AclTreeNode::delete_user_role (same) > - AclTreeNode::insert_group_role (same) > - AclTreeNode::insert_user_role (same) > - AclTree::write_config (we have save_config()) > - AclTree::load (we have config()/cached_config()) > > previously public, now crate-internal: > - AclTree::from_raw (only used by tests) > - split_acl_path (used by some test binaries) > thanks, thats makes it cleaner > Signed-off-by: Fabian Grünbichler > --- > RFC to get some feedback on which rustdoc features we actually want to > use here, and which we want to leave out for now. > Anything specific you want comments for, I mean I only skimmed through it quickly so may have overlooked stuff, but it seems like its mostly links which are new in usage? As long its a stable supported rustdoc feature available by the rust version we use I'm all for being able to use it.