From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B5B169E16F for ; Mon, 27 Nov 2023 10:14:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 917602DDB for ; Mon, 27 Nov 2023 10:13:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 27 Nov 2023 10:13:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CADE744A17 for ; Mon, 27 Nov 2023 10:13:34 +0100 (CET) Message-ID: <42798cdd-5ab1-43ef-8661-c017ff410f8a@proxmox.com> Date: Mon, 27 Nov 2023 10:13:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB-large To: Proxmox Backup Server development discussion , Gabriel Goller , Lukas Wagner References: <20231124120228.180173-1-g.goller@proxmox.com> <59e58a82-a881-4b95-8f8d-45669bbb12e1@proxmox.com> <329f626f-e78d-413f-9220-deed3621f7a7@proxmox.com> From: Thomas Lamprecht In-Reply-To: <329f626f-e78d-413f-9220-deed3621f7a7@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH v2 proxmox{-backup, } 0/3] Add boot_mode, improve kernel version X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2023 09:14:05 -0000 On 27.11.23 09:56, Gabriel Goller wrote: > On a second note, I don't like this. > We don't support enum variants (fields) with the `api` macro, so I would > have to create > a struct containing `mode` and `secureboot`. That again implies that > bios + secureboot is > possible, which is not. No that really does not imply that, especially if you use an option fro secureboot. > But I get your argument about consistency between products, so if we'd > go that > way, I'd send another patch with the requested changes... > Just to be fully sure: we will NOT take anything in here that isn't 1:1 compatible with what PVE produces on the line (i.e., serialized) what it looks internal I do not bother (that much).