From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A509B93954 for ; Mon, 19 Sep 2022 12:24:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A2CFEEE4 for ; Mon, 19 Sep 2022 12:24:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 19 Sep 2022 12:24:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F168942FEF for ; Mon, 19 Sep 2022 12:24:19 +0200 (CEST) Message-ID: <4195287a-9de0-4199-182f-9afd3a721307@proxmox.com> Date: Mon, 19 Sep 2022 12:24:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: Fiona Ebner , pbs-devel@lists.proxmox.com References: <20220914105039.186907-1-m.heiserer@proxmox.com> <20220914105039.186907-2-m.heiserer@proxmox.com> From: Matthias Heiserer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.656 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.657 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] prune-simulator: allow setting a time on which prune happens X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2022 10:24:20 -0000 On 16.09.2022 12:08, Fiona Ebner wrote: > Same nit for the commit title. > > Am 14.09.22 um 12:50 schrieb Matthias Heiserer: >> @@ -726,6 +730,15 @@ Ext.onReady(function() { >> padding: '0 0 0 10', >> value: new Date(), >> }, >> + { >> + xtype: 'timefield', >> + name: 'currentTime', >> + reference: 'currentTime', >> + fieldLabel: 'Time of prune', > > I don't really like using "Time of prune" here, because the setting also > affects the schedule and doesn't feel in line with "Today". How about > "Today's time" or simply "Time"? Or we could use "Current date" and > "Current time". I think just "Time" works best. I'll also rename the date field to "Date" to keep it consistent (and because it makes more sense; from the view of the user, its not the current date, but the date which is used for the simulation). > > There's AM/PM times in the drop-down suggestions here, which clashes > with the 24 hour format used in the rest of the simulator. Let's try to > keep it consistent. > Of course, good catch >> + allowBlank: false, >> + padding: '0 0 0 10', >> + value: new Date(), >> + }, >> ], >> }, >> ],