From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CE29D1FF38A for ; Fri, 28 Jun 2024 14:25:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 19F5B372F0; Fri, 28 Jun 2024 14:25:52 +0200 (CEST) Message-ID: <414947c1-2a62-418f-a97c-c550368c490f@proxmox.com> Date: Fri, 28 Jun 2024 14:25:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Christian Ebner , Wolfgang Bumiller References: <20240624142415.41470-1-c.ebner@proxmox.com> <1897229403.670.1719244415488@webmail.proxmox.com> <9114c156-ef5a-4ca1-8383-14dc087fe815@proxmox.com> <750157630.1179.1719577219520@webmail.proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner In-Reply-To: <750157630.1179.1719577219520@webmail.proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-rrd] cache: skip non-utf8 lines in rrd journal X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 2024-06-28 14:20, Christian Ebner wrote: >> On 28.06.2024 14:09 CEST Wolfgang Bumiller wrote: >> Do we even have anything non-ASCII in that file? >> I'd think the file got corrupted some other way. >> So would we really want to apply it? Perhaps just let the admin >> clear/remove it? > > No, the file should per se be valid UTF-8, even ASCII only. > I already replied to the user to clean up the file to solve the issue, fine by me if this is discarded. > The journal is applied on daemon startup and every 30 mins - so it should be fine to just discard it, one loses only up to 30mins of metric data - which doesn't sound so bad for a rare data corruption like this. -- - Lukas _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel