From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 300C0CDA9 for ; Tue, 19 Sep 2023 15:38:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 13D64B365 for ; Tue, 19 Sep 2023 15:38:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 19 Sep 2023 15:38:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4B8B647FC6 for ; Tue, 19 Sep 2023 15:38:01 +0200 (CEST) Message-ID: <40808fbd-70c7-4c95-a335-67e079891345@proxmox.com> Date: Tue, 19 Sep 2023 15:37:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Lukas Wagner To: Proxmox Backup Server development discussion , Hannes Laimer References: <20230915065457.352953-1-h.laimer@proxmox.com> <20230915065457.352953-4-h.laimer@proxmox.com> Content-Language: de-AT, en-US In-Reply-To: <20230915065457.352953-4-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 03/23] maintenance: add 'Unpplugged' maintenance type X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2023 13:38:32 -0000 On 9/15/23 08:54, Hannes Laimer wrote: > + > +#[test] > +fn test_check() { > + let ro_mode = MaintenanceMode::new(MaintenanceType::ReadOnly, None); > + let offline_mode = MaintenanceMode::new(MaintenanceType::Offline, None); > + let delete_mode = MaintenanceMode::new(MaintenanceType::Delete, None); > + let unplugged_mode = MaintenanceMode::new(MaintenanceType::Unplugged, None); > + > + assert!(ro_mode.check(Some(Operation::Lookup)).is_ok()); > + assert!(ro_mode.check(Some(Operation::Read)).is_ok()); > + assert!(ro_mode.check(Some(Operation::Write)).is_err()); > + > + assert!(offline_mode.check(Some(Operation::Lookup)).is_ok()); > + assert!(offline_mode.check(Some(Operation::Read)).is_err()); > + assert!(offline_mode.check(Some(Operation::Write)).is_err()); > + > + assert!(delete_mode.check(Some(Operation::Lookup)).is_err()); > + assert!(delete_mode.check(Some(Operation::Read)).is_err()); > + assert!(delete_mode.check(Some(Operation::Write)).is_err()); > + > + assert!(unplugged_mode.check(Some(Operation::Lookup)).is_err()); > + assert!(unplugged_mode.check(Some(Operation::Read)).is_err()); > + assert!(unplugged_mode.check(Some(Operation::Write)).is_err()); > +} It's always advisable to have tests in separate submodule: #[cfg(test)] mod tests { use super::*; #[test] fn test_check() { ... } } This makes sure that the test(s) is/are not compiled during a normal build :) -- - Lukas