From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6635093EB2 for ; Mon, 9 Jan 2023 12:00:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4F85B2C0D7 for ; Mon, 9 Jan 2023 12:00:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 9 Jan 2023 12:00:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 996AD4490B for ; Mon, 9 Jan 2023 12:00:57 +0100 (CET) Message-ID: <3fa785cf-b203-ebc4-8a3d-ea1cd07175ad@proxmox.com> Date: Mon, 9 Jan 2023 12:00:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Content-Language: en-US To: Wolfgang Bumiller Cc: pbs-devel@lists.proxmox.com References: <20230103142308.656240-1-l.wagner@proxmox.com> <20230103142308.656240-7-l.wagner@proxmox.com> <20230104133206.czwci777swboxggi@casey.proxmox.com> From: Lukas Wagner In-Reply-To: <20230104133206.czwci777swboxggi@casey.proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.173 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 06/17] auth: add LDAP realm authenticator X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2023 11:00:58 -0000 On 1/4/23 14:32, Wolfgang Bumiller wrote: >> +impl ProxmoxAuthenticator for LDAP { >> + /// Authenticate user in LDAP realm >> + fn authenticate_user(&self, username: &UsernameRef, password: &str) -> Result<(), Error> { >> + let ldap_config = ldap_api_type_to_ldap_config(&self.config)?; >> + >> + let ldap = LdapConnection::new(ldap_config); >> + >> + proxmox_async::runtime::block_on(ldap.authenticate_user(username.as_str(), password)) >> + } >> + >> + fn store_password(&self, _username: &UsernameRef, _password: &str) -> Result<(), Error> { >> + // do not store password for LDAP users >> + Ok(()) > Actually this should fail. > Otherwise this will make change-password API calls "succeed" without > actually doing anything, but IMO it makes more sense to return a > meaningful error there. > > (Perhaps even a http_bail!(NOT_IMPLEMENTED) though I'm not really sure > how the GUI would deal with that 😉 ) > Good point. I considered returning a failure here as well, but in the end I decided against it because the PAM authenticator also returns no failure if one attempts to `remove_password`. I guess it would make sense then to return a failure there as well? -- - Lukas