From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CBECAB3DE3 for ; Wed, 29 Nov 2023 15:59:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE6BF9F37 for ; Wed, 29 Nov 2023 15:59:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 29 Nov 2023 15:59:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DE39340EF9; Wed, 29 Nov 2023 15:59:47 +0100 (CET) Message-ID: <3ed0d2ab-d0be-493a-9343-66bbb2b69072@proxmox.com> Date: Wed, 29 Nov 2023 15:59:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Content-Language: en-US To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20231129110309.2524356-1-d.csapak@proxmox.com> From: Dominik Csapak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] ui: add 'show repository Information' button for datastores X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2023 14:59:48 -0000 On 11/29/23 15:53, Thomas Lamprecht wrote: > Am 29/11/2023 um 12:03 schrieb Dominik Csapak: >> this has a similar functionality as the 'show fingerprint' button, >> but for repository strings that are needed e.g. for the cli >> >> included with and without the current user for convenience >> > > datastore should be copyable too, and could be nice if the host (ip or domain, > maybe just document.location.hostname) would be visble separately too. > > Potentially divide the repo stuff for CLI a bit of with a extra line that > spots a "Repository for CLI and API" label (or the like) > > W.r.t. button placement, to the contrary of my intial suggestion I might > prefer it at the start of the summary view's top bar (where the RRD range > selector is). similar to the "Package Versions" button in PVE's node > summary. only there, or leave it at the datastore list summary too? > > An onlineHelp reference to "Backup Repository Locations" as Fabian suggests > would be really a good idea, as is the missing padding for the copy buttons, > and those could be a bit less flashy by using the inline buttons (or toolbar > button, always forget what we/ExtJS name it) styling. > makes all sense, do you have a preference for the button text (i.e. fabians suggestion 'show client information' or 'show connection info' like you offlist suggested?) i'd then have: datastore hostname fingerprint "repository for cli and api"( repository with current user sounds ok ?