From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <f.schauer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id E5FE693A29
 for <pbs-devel@lists.proxmox.com>; Tue,  9 Apr 2024 14:16:34 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id CD48A1D617
 for <pbs-devel@lists.proxmox.com>; Tue,  9 Apr 2024 14:16:34 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pbs-devel@lists.proxmox.com>; Tue,  9 Apr 2024 14:16:34 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 15FC34170C
 for <pbs-devel@lists.proxmox.com>; Tue,  9 Apr 2024 14:16:34 +0200 (CEST)
Message-ID: <3e418de5-0919-4e6c-905b-79e6bb1c2dbb@proxmox.com>
Date: Tue, 9 Apr 2024 14:16:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: pbs-devel@lists.proxmox.com
References: <20240403094913.107177-1-f.schauer@proxmox.com>
 <20240403094913.107177-5-f.schauer@proxmox.com>
 <D0AKMKR83AZ9.3OPFXZ57U9FMZ@proxmox.com>
From: Filip Schauer <f.schauer@proxmox.com>
In-Reply-To: <D0AKMKR83AZ9.3OPFXZ57U9FMZ@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.077 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH vma-to-pbs 4/9] add support for streaming
 the VMA file via stdin
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 09 Apr 2024 12:16:34 -0000

On 03/04/2024 16:52, Max Carrara wrote:
>> +    let elapsed_ms = SystemTime::now()
>> +        .duration_since(start_transfer_time)?
>> +        .as_millis();
>> +    println!(
>> +        "Backup finished within {} minutes, {} seconds and {} ms",
>> +        elapsed_ms / 1000000,
>> +        (elapsed_ms / 1000) % 60,
>> +        elapsed_ms % 1000
>> +    );
> The seconds are not calculated correctly here: 1s = 60_000ms
>
> To make it less error prone, you could just use seconds by default and
> milliseconds where necessary, e.g.:
>
>      let total_seconds = duration.as_secs();
>
>      let minutes = total_seconds / 60;
>      let seconds = total_seconds % 60;
>      let milliseconds = duration.as_millis() % 1000;

I don't see what about my seconds calculation is wrong, but I adapted
the code anyway to make it less confusing.