From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BB350CD39 for ; Tue, 12 Apr 2022 17:00:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE50519C00 for ; Tue, 12 Apr 2022 17:00:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 69AA119BF2 for ; Tue, 12 Apr 2022 17:00:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2152A416AD for ; Tue, 12 Apr 2022 17:00:43 +0200 (CEST) Message-ID: <3e27f3ac-17ff-8f51-32e6-3dd71221cb63@proxmox.com> Date: Tue, 12 Apr 2022 17:00:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Hannes Laimer References: <20220412052601.4709-1-h.laimer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220412052601.4709-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [restore.rs, maintenance.rs, proxmox-backup-proxy.rs, status.rs, pull.rs, mod.rs, datastore.rs, proxmox-backup-api.rs, lib.rs, backup.rs] Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v10 0/6] closes #3071: maintenance mode for datastore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2022 15:00:44 -0000 On 12.04.22 07:25, Hannes Laimer wrote: > Hannes Laimer (6): > api-types: add maintenance type > datastore: add check for maintenance in lookup > pbs-datastore: add active operations tracking > api: make maintenance_type updatable > api: add get_active_operations endpoint > ui: add option to change the maintenance type > > pbs-api-types/Cargo.toml | 2 +- > pbs-api-types/src/datastore.rs | 23 ++++- > pbs-api-types/src/lib.rs | 3 + > pbs-api-types/src/maintenance.rs | 78 +++++++++++++++++ > pbs-datastore/Cargo.toml | 1 + > pbs-datastore/src/datastore.rs | 126 +++++++++++++++++++-------- > pbs-datastore/src/lib.rs | 4 + > pbs-datastore/src/snapshot_reader.rs | 6 +- > pbs-datastore/src/task_tracking.rs | 110 +++++++++++++++++++++++ > src/api2/admin/datastore.rs | 81 +++++++++++------ > src/api2/backup/mod.rs | 4 +- > src/api2/config/datastore.rs | 5 ++ > src/api2/reader/mod.rs | 6 +- > src/api2/status.rs | 4 +- > src/api2/tape/backup.rs | 6 +- > src/api2/tape/restore.rs | 6 +- > src/bin/proxmox-backup-api.rs | 1 + > src/bin/proxmox-backup-proxy.rs | 4 +- > src/server/mod.rs | 16 +++- > src/server/prune_job.rs | 4 +- > src/server/pull.rs | 4 +- > src/server/verify_job.rs | 4 +- > www/Makefile | 1 + > www/Utils.js | 23 +++++ > www/datastore/OptionView.js | 30 +++++++ > www/window/MaintenanceOptions.js | 77 ++++++++++++++++ > 26 files changed, 539 insertions(+), 90 deletions(-) > create mode 100644 pbs-api-types/src/maintenance.rs > create mode 100644 pbs-datastore/src/task_tracking.rs > create mode 100644 www/window/MaintenanceOptions.js > applied series, thanks! In the UI I fixed the leaking of the tasks tracking storage (needed an explicit stop on deactivate/destroy event of the option view panel like we had for the existing rstore) and also patched the renderer to show also the message inline. What's still missing, or up for improvement: * show the maintenance mode in the datastore summary (or just plainly in the "Datastore: " heading of the panel?); as currently it's rather subtle * Improve failure mode in offline mode, e.g., the summary page then is just plank/broken and the content view shows a loading error/mask that won't get removed until reload even if one reset the maintenance mode to none again, at least FWICT Both mostly cosmetical, but quite important IMO for UX and to avoid user confusion.