From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F199CB83B1 for ; Thu, 7 Mar 2024 15:11:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D2E3F3798F for ; Thu, 7 Mar 2024 15:11:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 7 Mar 2024 15:11:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0D10F40F9B for ; Thu, 7 Mar 2024 15:11:05 +0100 (CET) Message-ID: <3d94259f-7621-4bea-ae75-efc7749fd910@proxmox.com> Date: Thu, 7 Mar 2024 15:11:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US, de-DE To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20240306141153.419283-1-c.ebner@proxmox.com> <9eb2e30b-52fd-4624-b2f4-7b653b7bb374@proxmox.com> From: Christian Ebner In-Reply-To: <9eb2e30b-52fd-4624-b2f4-7b653b7bb374@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.040 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] applied-series: [PATCH proxmox-backup 0/3] fix #5285: log global statistics for sync job X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2024 14:11:06 -0000 On 3/7/24 14:59, Thomas Lamprecht wrote: > > Albeit for such things it would be nice to add an example (excerpt) of the > new message/format in the commit message – I amended the respective commit > with that. Thanks, will keep that in mind for next time. > > I also found a glitch for the case where no new data was pulled, as then > one got the following log entry: > >> Summary: sync job pulled 0 B in 0 chunks (average rate: NaN B/s) > > I made a follow-up commit that makes the API log a different messages > in that case. Had that case as well, but was thinking of taking a look at how to better handle such a `NaN` case in the `human_byte` crate. But I agree, the output is cleaner with your followup. > > Something that might be still relevant is mentioning the amount of > deleted (vanished) backups/groups in the summary. Okay, will have a look at integrating that as well. Thanks for your comments and to Max for review and testing!