From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <m.limbeck@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 1B5F990D43
for <pbs-devel@lists.proxmox.com>; Mon, 2 Oct 2023 12:17:09 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id F235D15F08
for <pbs-devel@lists.proxmox.com>; Mon, 2 Oct 2023 12:16:38 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Mon, 2 Oct 2023 12:16:38 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 177EC48EA5
for <pbs-devel@lists.proxmox.com>; Mon, 2 Oct 2023 12:16:38 +0200 (CEST)
Message-ID: <3cdbab95-4aea-5b02-5f40-d4be27ea48a2@proxmox.com>
Date: Mon, 2 Oct 2023 12:16:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
Thunderbird/102.15.1
Content-Language: en-US
To: pbs-devel@lists.proxmox.com
References: <20231002075229.3055009-1-d.csapak@proxmox.com>
From: Mira Limbeck <m.limbeck@proxmox.com>
In-Reply-To: <20231002075229.3055009-1-d.csapak@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 1.764 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -3.058 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: tape: restore: fix
default namespace mapping
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 02 Oct 2023 10:17:09 -0000
On 10/2/23 09:52, Dominik Csapak wrote:
> the ui shows the default 'root' namespace as target, but this only
> worked when no namespace was selected. as soon as one source datastore
> had a target namespace selected, the others datastores would be skipped
> as there was no namespace mapping for them. To fix that, we simply send
> a default namespace mapping for each source datastore without a target
> (no target means 'root')
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/tape/window/TapeRestore.js | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
> index c1d3493c..988ceba2 100644
> --- a/www/tape/window/TapeRestore.js
> +++ b/www/tape/window/TapeRestore.js
> @@ -537,6 +537,8 @@ Ext.define('PBS.TapeManagement.DataStoreMappingGrid', {
> let ns = targetns || defaultNs;
> if (ns) {
> namespaces.push(`store=${source},target=${ns}`);
> + } else {
> + namespaces.push(`store=${source}`);
> }
> }
> });
Worked as expected in my tests. Consider it:
Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
one thing that popped up, unrelated to this patch, it seems the
datastore order in the mapping form changes sometimes.