From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C70E584E08 for ; Thu, 16 Dec 2021 09:20:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B9A2A1B809 for ; Thu, 16 Dec 2021 09:20:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9AF801B7FE for ; Thu, 16 Dec 2021 09:20:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6411E42B56 for ; Thu, 16 Dec 2021 09:20:13 +0100 (CET) Message-ID: <3c14a5fa-3422-504c-bfa3-8da9494d2271@proxmox.com> Date: Thu, 16 Dec 2021 09:20:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Content-Language: en-US To: Dominik Csapak , Proxmox Backup Server development discussion References: <20211215091952.1490583-1-d.csapak@proxmox.com> <20211215091952.1490583-3-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.090 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.034 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox v2 2/3] proxmox-sys: add DiskUsage struct and helper X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Dec 2021 08:20:14 -0000 On 16.12.21 09:15, Dominik Csapak wrote: > On 12/15/21 13:41, Thomas Lamprecht wrote: >> On 15.12.21 10:19, Dominik Csapak wrote: >>> @@ -102,3 +103,28 @@ impl CreateOptions { >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ >>> =C2=A0 } >>> =C2=A0 +/// Basic disk usage information >> >> would add the source, e.g.: ... derived from what statfs64 reports >> >>> +#[derive(Serialize)] >>> +pub struct DiskUsage { >> >> Is DiskUsage really a good name here? As with "Disk" I thing block lev= el, but >> this is filesystem level.. Maybe FileSystemUsage (shorteting to FSUsag= e could >> be done, but that's not helping that much.. >=20 > how about FileSystemInformation (or FSInfo if the length is a problem)?= IMHO "usage" is wrong if we include things like the type or id not really wrong to include an ID to any info for tracking purpose, I mea= n the syscall also returns that and is named "StatFS", so that's fine, its wron= g to name it disk, but using "info" or "usage" won't create any big confusion = either way IMO, no hard feelings there.