From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2361B1FF173 for ; Mon, 25 Nov 2024 12:30:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EB40D11442; Mon, 25 Nov 2024 12:30:48 +0100 (CET) Message-ID: <377618fd-0ea9-46ba-9aec-a47387eca50d@proxmox.com> Date: Mon, 25 Nov 2024 12:30:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Dominik Csapak References: <20241125111537.1504618-1-d.csapak@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20241125111537.1504618-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.119 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/6] sync job ui improvements X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 11/25/24 12:15, Dominik Csapak wrote: > this series aims to improve the pull/push sync job ui a bit, by: > > * unifying both types into one list Not sure if you are aware of this, but we decided early on [0] to explicitly separate the list for both directions to reduce possible misconfiguration for the user. That is also why the sync jobs in push direction have their dedicated config type instead of having the direction as property of the sync job. [0] https://lore.proxmox.com/pbs-devel/5be4c3d1-593f-4eec-b21b-33cb3afc9216@proxmox.com/ > * adding a helpful tooltip for local owner/user > * adding a filter for the sync jobs > * adding a 'all' mode for listing all jobs on the /admin/sync api > > Dominik Csapak (6): > api: admin: sync: add direction to sync job status > api: admin: sync: add optional 'all' sync type for listing > cli: manager: sync: add 'sync-direction' parameter to list > ui: sync jobs: revert to single list for pull/push jobs > ui: sync jobs: change default sorting to 'store' -> 'direction' -> > 'id' > ui: sync jobs: add search box > > pbs-api-types/src/jobs.rs | 6 ++ > src/api2/admin/sync.rs | 65 ++++++++---- > src/api2/config/datastore.rs | 9 +- > src/api2/config/notifications/mod.rs | 2 +- > src/bin/proxmox_backup_manager/sync.rs | 6 +- > www/Makefile | 1 - > www/config/SyncPullPushView.js | 61 ----------- > www/config/SyncView.js | 134 ++++++++++++++++++++----- > www/datastore/DataStoreList.js | 2 +- > www/datastore/Panel.js | 2 +- > 10 files changed, 178 insertions(+), 110 deletions(-) > delete mode 100644 www/config/SyncPullPushView.js > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel