From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C41DD68E57 for ; Wed, 11 Nov 2020 18:39:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B937A26E39 for ; Wed, 11 Nov 2020 18:39:00 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9BCE226E2D for ; Wed, 11 Nov 2020 18:38:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 65DFA46005 for ; Wed, 11 Nov 2020 18:38:59 +0100 (CET) To: Proxmox Backup Server development discussion , Mira Limbeck References: <20201110132218.17717-1-m.limbeck@proxmox.com> <20201110132218.17717-2-m.limbeck@proxmox.com> From: Thomas Lamprecht Message-ID: <36cbccc4-340b-933b-63d7-921bc332a25b@proxmox.com> Date: Wed, 11 Nov 2020 18:38:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201110132218.17717-2-m.limbeck@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.097 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [report.rs, proxmox-backup-manager.rs] Subject: [pbs-devel] applied: [PATCH v2 proxmox-backup 2/2] add versions command to proxmox-backup-manager X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2020 17:39:00 -0000 On 10.11.20 14:22, Mira Limbeck wrote: > Add the versions command to proxmox-backup-manager with a similar outpu= t > to pveversion [-v]. It prints the packages line by line with only the > package name, followed by the version and, for proxmox-backup and > proxmox-backup-server, some additional information (running kernel, > running version). >=20 > In addition it supports the optional output-format parameter which can > be used to print the complete data in either json, json-pretty or text > format. If output-format is specified, the --verbose parameter is > ignored and the detailed list of packages is printed. >=20 > With the addition of the versions command, the report is extended as > well. >=20 > Signed-off-by: Mira Limbeck > --- > v2: > - removed the special casing for running kernel and running version= > as the get_versions result already contains the complete string > - fixed version string to print 'not correctly installed' instead o= f > 'unknown' if no old_version is available >=20 > src/bin/proxmox-backup-manager.rs | 78 +++++++++++++++++++++++++++++++= > src/server/report.rs | 1 + > 2 files changed, 79 insertions(+) >=20 > applied, thanks! I did a followup reducing this to a more unified code, c= hipping of ~ 30 lines, single thing I'm unhappy with is the de-structuring and re= building for slicing out the first package info in the non-verbose case, so if one= has better ideas/nicer code there... What I found a bit weird that the verbose flag was effectively also trigg= ered indirectly, by setting an output-format. One thing I noticed, the CLI argument parser does not recognizes the shor= t option here (-v) - just noting it.