From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id E655677231 for ; Tue, 20 Jul 2021 09:02:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id D27EA2C4BD for ; Tue, 20 Jul 2021 09:01:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id 634F82C4AE for ; Tue, 20 Jul 2021 09:01:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id 2095E42266; Tue, 20 Jul 2021 09:01:41 +0200 (CEST) Message-ID: <362a96bd-54bb-206a-4de3-d5c162da7cc3@proxmox.com> Date: Tue, 20 Jul 2021 09:01:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0 Content-Language: en-US To: Dietmar Maurer , Proxmox Backup Server development discussion References: <509050131.1964.1626761748892@webmail.proxmox.com> From: Dominik Csapak In-Reply-To: <509050131.1964.1626761748892@webmail.proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.558 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/3] tape: media_catalog: add fast_catalog beside normal catalog X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2021 07:02:11 -0000 On 7/20/21 08:15, Dietmar Maurer wrote: > >> On 07/19/2021 4:55 PM Dominik Csapak wrote: >> >> >> for some parts of the ui, we only need the snapshot list from the catalog, >> and reading the whole catalog (can be multiple hundred MiB) is not >> really necessary. >> >> Instead, on every commit of the catalog, write the complete content list >> into a seperate .index file, that can be read to get only the snapshot >> list. > > Commits can be quite frequent. Can we write on "close" only? > AFAICS from the code, during a backup to tape, we only commit on tape end (the "close") or every 128GiB written to tape so not that often (every ~7 minutes on LTO-8 with 300MB/s) on tape restore though, we create a 'temporary database' which gets commited on every archive restore i'd suggest to either * add an option to commit for writing the snapshot list, and only set it on the last commit * add some kind of 'finish' or 'close' function to the catalog, that must be called any favorites (or alternatives) ?