From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 957DFB35F5 for ; Wed, 29 Nov 2023 08:35:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6ED3FC1F for ; Wed, 29 Nov 2023 08:35:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 29 Nov 2023 08:35:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 98C264226F; Wed, 29 Nov 2023 08:35:56 +0100 (CET) Message-ID: <3617045f-a415-4ce0-9548-9f7c83b14943@proxmox.com> Date: Wed, 29 Nov 2023 08:35:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20231128094402.38115-1-d.csapak@proxmox.com> <20231128094402.38115-4-d.csapak@proxmox.com> <2dfe28d8-8f26-496d-9da8-9f3bcb99b15c@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <2dfe28d8-8f26-496d-9da8-9f3bcb99b15c@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup 3/5] ui: datastore content: add context menu to groups and snapshots X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2023 07:35:57 -0000 On 11/28/23 16:27, Thomas Lamprecht wrote: > Am 28/11/2023 um 10:44 schrieb Dominik Csapak: >> and show the relevant actions. They will be forwarded to the controller, >> so we can reuse that code without big refactoring them into another >> class/place. >> >> Signed-off-by: Dominik Csapak >> --- >> sadly no keyboard navigation in there.. but i'm looking into it >> >> www/datastore/Content.js | 114 +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 114 insertions(+) >> >> > > applied this one for now, thanks! > > Albeit, I'm wondering if we should add the ID into the menu header, for > snapshots that tends to be a bit large though... yeah i tried that, but couldn't make it look ok and consistent, so i left it out. If you have an idea how to format it (maybe "type \n id \n time" ?) it should be relatively trivial to implement. > > Oh, and fwiw, we could add a "Copy Text" for the cells where it makes > sense (ID of group or snapshot, comment firt line, maybe date) so that > one has it slightly easier if they found the wanted snapshot/group here > and what to use that ID for, e.g., finding that in the PVE storage > content UI, but no hard feelings, just as an idea. yeah that could make sense, or maybe easier if we allow selecting the text of the cells directly? that way the users can select copy themselves. (we'd have to show the context menu depending on if text is selected or not of course, but that should be doable without much issues)