From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 91A3999C3F for ; Wed, 11 Oct 2023 13:07:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 732867B91 for ; Wed, 11 Oct 2023 13:07:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 11 Oct 2023 13:07:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E425344A2F for ; Wed, 11 Oct 2023 13:07:15 +0200 (CEST) Message-ID: <34fdf6c1-23dd-4067-a5cb-de4398a2d937@proxmox.com> Date: Wed, 11 Oct 2023 13:07:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Gabriel Goller To: pbs-devel@lists.proxmox.com Reply-To: Proxmox Backup Server development discussion References: <20230918134109.179258-1-g.goller@proxmox.com> <20230918134109.179258-3-g.goller@proxmox.com> In-Reply-To: <20230918134109.179258-3-g.goller@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.360 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] datastore: catalog: added lifetime to find function X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2023 11:07:47 -0000 bump. On 9/18/23 15:41, Gabriel Goller wrote: > Added lifetime to `find` function. We need this lifetime > because of the `impl MatchList` and 'anonymous lifetimes in > `impl Trait` are unstable'. > > Signed-off-by: Gabriel Goller > --- > pbs-datastore/src/catalog.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/pbs-datastore/src/catalog.rs b/pbs-datastore/src/catalog.rs > index 86e20c92..eb531837 100644 > --- a/pbs-datastore/src/catalog.rs > +++ b/pbs-datastore/src/catalog.rs > @@ -661,11 +661,11 @@ impl CatalogReader { > > /// Finds all entries matching the given match patterns and calls the > /// provided callback on them. > - pub fn find( > + pub fn find<'a>( > &mut self, > parent: &DirEntry, > file_path: &mut Vec, > - match_list: &impl MatchList, //&[MatchEntry], > + match_list: &'a impl MatchList<'a>, //&[MatchEntry], > callback: &mut dyn FnMut(&[u8]) -> Result<(), Error>, > ) -> Result<(), Error> { > let file_len = file_path.len();