Re: [pbs-devel] applied-series: [PATCH v7 proxmox-backup 00/31] fix #3044: push datastore to remote target

From: Christian Ebner <c.ebner@proxmox.com>
To: "Proxmox Backup Server development discussion"
	<pbs-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pbs-devel] applied-series: [PATCH v7 proxmox-backup 00/31] fix #3044: push datastore to remote target
Date: Thu, 21 Nov 2024 13:26:40 +0100	[thread overview]
Message-ID: <3463fa78-61bd-49aa-96bb-36f376981767@proxmox.com> (raw)
In-Reply-To: <1732190636.gvupqrayxw.astroid@yuna.none>

On 11/21/24 13:08, Fabian Grünbichler wrote:
> with some follow-ups, notably:
> 
> - dropped the named features, checking just the api version instead
> - simplified the namespace filtering
> - added a new datastore_api_path helper
> - add a check whether the source namespace anchor exists
> - simplify the snapshot selection for remove_vanished
> - reduce the (expensive) queries to the remote snapshot lists
> - some code simplification and style cleanups
> 
> the error handling/contexts could still benefit from some attention
> (mostly making clear where an error from the remote side is bubbled up,
> since the ACL paths are confusing if that context is not included), but
> that can be done as follow-up..

Acked, thanks a lot for all your input on this series!

Will look at the suggested improved error handling right away.

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel