From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 761CC1FF168 for ; Tue, 26 Nov 2024 17:25:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D261975C7; Tue, 26 Nov 2024 17:25:48 +0100 (CET) Message-ID: <33c92137-b2cb-4e91-820d-bd3d96756662@proxmox.com> Date: Tue, 26 Nov 2024 17:25:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: pbs-devel@lists.proxmox.com References: <20241126162005.85583-1-f.ebner@proxmox.com> <20241126162005.85583-2-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: <20241126162005.85583-2-f.ebner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v2 widget-toolkit] form: display-edit: support emptyText X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Am 26.11.24 um 17:20 schrieb Fiona Ebner: > To access the edit field, its xtype is now tracked. > > First user is intended to be the path field for datastores where the > emptyText should dynamically be for a relative or absolute path. > > Signed-off-by: Fiona Ebner > --- > > Changes in v2: > * avoid tracking emptyText state twice, pass directly to edit field. > > src/form/DisplayEdit.js | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/src/form/DisplayEdit.js b/src/form/DisplayEdit.js > index fe1b83b..01d6a05 100644 > --- a/src/form/DisplayEdit.js > +++ b/src/form/DisplayEdit.js > @@ -12,6 +12,9 @@ Ext.define('Proxmox.form.field.DisplayEdit', { > > displayType: 'displayfield', > > + // internal only, use editConfig to set the xtype > + _editType: 'textfield', > + > editConfig: {}, > editable: false, > setEditable: function(editable) { > @@ -41,6 +44,15 @@ Ext.define('Proxmox.form.field.DisplayEdit', { > vm.get('value'); > }, > > + setEmptyText: function(emptyText) { > + let me = this; > + me.down(me._editType).setEmptyText(emptyText); > + }, > + getEmptyText: function() { > + let me = this; > + return me.down(me._editType).getEmptyText(); > + }, > + > layout: 'fit', > defaults: { > hideLabel: true, > @@ -64,6 +76,8 @@ Ext.define('Proxmox.form.field.DisplayEdit', { > }); > Ext.applyIf(editConfig, displayConfig); > > + me.__editType = editConfig.xtype; Sorry, there is a typo here, __editType instead of _editType > + > if (me.initialConfig && me.initialConfig.displayConfig) { > Ext.applyIf(displayConfig, me.initialConfig.displayConfig); > delete displayConfig.displayConfig; _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel