From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id F1EB41FF09B for ; Mon, 31 Aug 2026 14:06:01 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 27651212DE; Mon, 31 Aug 2026 14:06:01 +0200 (CEST) Message-ID: <3311b35e-a85e-4db9-9572-aa11cc7f385e@proxmox.com> Date: Mon, 31 Aug 2026 14:05:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-backup] ui: datastore content: allow moving namespace from parent To: pbs-devel@lists.proxmox.com References: <20260831113539.2622191-1-d.csapak@proxmox.com> Content-Language: en-US From: Jonas Theisen In-Reply-To: <20260831113539.2622191-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788177944686 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.718 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7LH7I2ERGM7VBR2VSQNSO6I3M5FJDUX7 X-Message-ID-Hash: 7LH7I2ERGM7VBR2VSQNSO6I3M5FJDUX7 X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/31/26 13:35, Dominik Csapak wrote: > having to go into the namespace to move it seems unintuitive, so allow > it from it's parent too. > > Only navigate to the new place when we were inside the namespace, > otherwise we stay at the one we were. > > Signed-off-by: Dominik Csapak > > -snip- Tested the patch by creating and moving Namespaces from the parent and sub level. Works as expected. With the patch applied the Root entry of a Namespace also has a move button and it references the current Namespace. This is probably not intentional and could cause confusion. -- Tested-By: Jonas Theisen