From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 745606B3BA for ; Tue, 26 Jan 2021 11:34:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5FD51150D0 for ; Tue, 26 Jan 2021 11:34:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E0968150C6 for ; Tue, 26 Jan 2021 11:34:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A589241A13 for ; Tue, 26 Jan 2021 11:34:55 +0100 (CET) To: pbs-devel@lists.proxmox.com References: <20210119110915.18864-1-d.jaeger@proxmox.com> From: Dominik Csapak Message-ID: <31f19138-bb58-1854-35f9-ef3023bb2c74@proxmox.com> Date: Tue, 26 Jan 2021 11:34:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210119110915.18864-1-d.jaeger@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.261 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/4] remote edit: error message ideas X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2021 10:34:56 -0000 ok after taking a look at it, there are some problems while i'd find the asterisk ok, the combination of patches here do not really work together well. when we have the error icon, we'd not need the asterisk, since they both show the error or were they not intended to be applied together? also, the generic tooltip does always show on the whole element for me, so with either the asterisk or the icon, i still get multiple tooltips over one another another problem is with the detection of the 'required' error. while this may work on english, extjs errors are also translated, though i noticed we do not do this yet for pbs (for pve we do) so filtering by 'required' cannot work for other languages and last but not least: would it not be possible to show the tooltip just on the label? e.g.: --- fieldLabel: `
${gettext('labeltext')}
' --- a little bit less intuitive, but should not create overlapping tooltips another alternative would be to add a displayfield below the field with an explanation? or simply add a screenshot with a list of fields to the documentation? On 1/19/21 12:09 PM, Dominic Jäger wrote: > Already talked about the first patch for #3058 with Thomas. Hope that this is > now acceptable. > > The rest is rather to show what we could maybe do and how much code that would > require. > > Dominic Jäger (4): > ui: remote edit: Add tooltips > ui: remote edit: Add asterisks > ui: remote edit: Error as symbol to the right > ui: remote edit: Change asterisk color > > www/Utils.js | 15 +++++++++++++++ > www/window/RemoteEdit.js | 35 +++++++++++++++++++++++++++++++++++ > 2 files changed, 50 insertions(+) >