From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 67E9F1FF163
	for <inbox@lore.proxmox.com>; Thu, 12 Sep 2024 11:39:26 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id CB2281D7F6;
	Thu, 12 Sep 2024 11:39:28 +0200 (CEST)
Date: Thu, 12 Sep 2024 11:38:54 +0200 (CEST)
From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, 
 Fiona Ebner <f.ebner@proxmox.com>, Gabriel Goller <g.goller@proxmox.com>
Message-ID: <317943379.28985.1726133934722@webmail.proxmox.com>
In-Reply-To: <e901351f-5b98-4946-8c82-f10c257bb1bd@proxmox.com>
References: <20240910130351.396746-1-g.goller@proxmox.com>
 <e901351f-5b98-4946-8c82-f10c257bb1bd@proxmox.com>
MIME-Version: 1.0
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev67
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.050 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH] log: fallback to stderr if syslog not
 available
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

also got filed as https://bugzilla.proxmox.com/show_bug.cgi?id=5712, might be nice to fold that into the commit title when applied..

> Fiona Ebner <f.ebner@proxmox.com> hat am 12.09.2024 11:29 CEST geschrieben:  
> Am 10.09.24 um 15:03 schrieb Gabriel Goller:
> > Don't panic when the syslog is not available - which happens commonly in
> > containers and sbuild environments (chroot and unshare) - instead
> > fallback to stderr.
> > 
> > Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> > ---
> > 
> > Note: this fixes `make sbuild` for pve-storage.
> > Disclaimer: haven't quite figured out why tbh, I don't see where the
> > verify_api function calls proxmox-backup-api or proxmox-backup-proxy. 
> > 
> 
> It's also used by libpve-rs and I can confirm "injecting" (done using
> sbuild options --starting-build-commands and --pre-build-commands) a
> package of libpve-rs-perl that incorporates your proxmox-log change
> makes building pve-storage and pve-container work again :)

just for the record or to save you some trouble the next time - injecting a changed package into the build env can simply be done via --extra-package (either pointed at the .deb file, or at a dir containing .deb files to be injected). --extra-repository also works, but requires exposing them as repository..
 
> Tested-by: Fiona Ebner <f.ebner@proxmox.com>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel