From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 69E1766EAB for ; Wed, 29 Jul 2020 07:14:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 53DA8A32B for ; Wed, 29 Jul 2020 07:14:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8D2BCA31B for ; Wed, 29 Jul 2020 07:14:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5C8D6433CC for ; Wed, 29 Jul 2020 07:14:17 +0200 (CEST) Date: Wed, 29 Jul 2020 07:13:41 +0200 (CEST) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Stefan Reiter Message-ID: <310469562.306.1595999622311@webmail.proxmox.com> In-Reply-To: <20200728123211.9276-1-s.reiter@proxmox.com> References: <20200728123211.9276-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.3-Rev17 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: fix error when reloading DataStoreContent X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2020 05:14:49 -0000 applied > On 07/28/2020 2:32 PM Stefan Reiter wrote: > > > ...when an entry is selected, that doesn't exist after the reload. > > E.g. when one deletes selects a file within a snapshot and then clicks > the delete icon for said snapshot, focusRow would then fail and the > loading mask stay on until a reload. > > Signed-off-by: Stefan Reiter > --- > www/DataStoreContent.js | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/www/DataStoreContent.js b/www/DataStoreContent.js > index 5f407e98..1c08f56a 100644 > --- a/www/DataStoreContent.js > +++ b/www/DataStoreContent.js > @@ -232,8 +232,10 @@ Ext.define('PBS.DataStoreContent', { > } > return selected === id; > }, undefined, true); > - view.setSelection(selection); > - view.getView().focusRow(selection); > + if (selection) { > + view.setSelection(selection); > + view.getView().focusRow(selection); > + } > } > > Proxmox.Utils.setErrorMask(view, false); > -- > 2.20.1 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel