From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7DF1B1FF17A for ; Tue, 11 Nov 2025 11:21:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C6508468E; Tue, 11 Nov 2025 11:22:26 +0100 (CET) Message-ID: <30794016-153e-4fe0-82fc-f6586e3a2b14@proxmox.com> Date: Tue, 11 Nov 2025 11:21:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Christian Ebner To: Proxmox Backup Server development discussion , Nicolas Frey References: <20251110084417.173290-1-n.frey@proxmox.com> Content-Language: en-US, de-DE In-Reply-To: <20251110084417.173290-1-n.frey@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762856490048 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} v3 0/9] parallelize chunk reads in verification X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 11/10/25 9:44 AM, Nicolas Frey wrote: > This patch series aims to expand on Dominik's series [0] written for > pbs 3, parallelizing chunk reads in `VerifyWorker` using a seperate > thread pool from the verification. > > The number of threads was previously hard-coded, but is now > configurable via the API and GUI with new properties called > `{read,verify}-threads`, similarly to tape backups. > > The number of threads should also be configurable through tuning > options or datastore config (as discussed by Chris & Thomas on list), > which can be added in a follow up patch series. > > In my local tests I measured the following speed difference: > verified a single snapshot with ~32 GiB (4x the RAM size) with 4 > cores (just changing the read threads) > > 1 thread: ~440MiB/s > 2 threads: ~780MiB/s > 4 threads: ~1140MiB/s > > [0] https://lore.proxmox.com/pbs-devel/20250707132706.2854973-1-d.csapak@proxmox.com/#t > > Changes since v2: > * split move to parallel handler into 2 seperate commits > * add constructor to `IndexVerifyState` and clean up nits > > Changes since v1, thanks to Chris: > * define dedicated schema for {worker,read,verify}-threads > * rebase proxmox-backup > * introduce new state struct `IndexVerifyState` to reduce the amount > of Arc clones and overall better bundling > * adjust update endpoint and UI to the new properties Series is looking good already, only a few smaller thing need some adaption (see individual patches). One major thing which should be however included is a short documentation of these parameters and what they do. Tested the configs are set as expected via cli/ui, default values are cleared, the logs expose the number of used reader/verify threads, parameters are actually used for the verification job. Consider the whole series: Tested-by: Christian Ebner _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel