From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CEE3C7D649 for ; Tue, 9 Nov 2021 09:31:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C26DD2F2A2 for ; Tue, 9 Nov 2021 09:31:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5931D2F297 for ; Tue, 9 Nov 2021 09:31:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2B55A42326 for ; Tue, 9 Nov 2021 09:31:13 +0100 (CET) To: Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20211028130058.1308810-1-f.gruenbichler@proxmox.com> <20211028130058.1308810-2-f.gruenbichler@proxmox.com> From: Dietmar Maurer Message-ID: <30378d98-7632-b644-6ff2-31665eec3719@proxmox.com> Date: Tue, 9 Nov 2021 09:31:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211028130058.1308810-2-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.499 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [schema.rs] Subject: [pbs-devel] applied: [PATCH v3 proxmox 1/1] updater: impl UpdaterType for Vec X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2021 08:31:13 -0000 applied On 10/28/21 3:00 PM, Fabian Grünbichler wrote: > by replacing the whole Vec. > > if we ever want to support adding/removing/modifying elements of a Vec > via the Updater, we'd need to extend it anyway (or use a custom > updater). > > Suggested-by: Dominik Csapak > Signed-off-by: Fabian Grünbichler > --- > proxmox-schema/src/schema.rs | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/proxmox-schema/src/schema.rs b/proxmox-schema/src/schema.rs > index 34135f4..5e6e818 100644 > --- a/proxmox-schema/src/schema.rs > +++ b/proxmox-schema/src/schema.rs > @@ -1179,6 +1179,11 @@ where > type Updater = T::Updater; > } > > +// this will replace the whole Vec > +impl UpdaterType for Vec { > + type Updater = Option; > +} > + > pub trait ApiType { > const API_SCHEMA: Schema; > }