From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id D9DEF1FF16A
for <inbox@lore.proxmox.com>; Fri, 30 Aug 2024 11:00:28 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 259C037ABB;
Fri, 30 Aug 2024 11:00:58 +0200 (CEST)
Date: Fri, 30 Aug 2024 11:00:25 +0200
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Message-ID: <2xgl6gaqg6hqo56kiyjukzqvhvwizm2uk4qvwrir3zqzsacmbw@a6mxr6ryb66p>
References: <20240808081825.325983-1-d.csapak@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20240808081825.325983-1-d.csapak@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.087 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: [pbs-devel] applied: [PATCH proxmox-backup] data_blob: add TODO
comment for zstd api
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
applied, thanks
On Thu, Aug 08, 2024 at 10:18:25AM GMT, Dominik Csapak wrote:
> we currently use the behavior of zstd that is not part of the public
> api, so this is at risk to be changed without notice.
>
> There is a public api that we could use, but it's only available
> with zstd_sys >= 2.0.9, which at this time, is not yet packaged for/by
> us.
>
> Add a comment that we can use the public api for this when the
> new version of the crate gets available.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> after looking whom to report that the api would benefit from better
> error handling, i noticed that zstd_sys already has what we need, but
> only in a newer version, which we currently don't package
>
> pbs-datastore/src/data_blob.rs | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/pbs-datastore/src/data_blob.rs b/pbs-datastore/src/data_blob.rs
> index fd84f4be..0fb4d44c 100644
> --- a/pbs-datastore/src/data_blob.rs
> +++ b/pbs-datastore/src/data_blob.rs
> @@ -556,6 +556,8 @@ impl<'a, 'b> DataChunkBuilder<'a, 'b> {
> ///
> /// There is a test below to ensure we catch any change in the interface or internal value.
> fn zstd_error_is_target_too_small(err: usize) -> bool {
> + // TODO: when zstd_sys >= 2.0.9 is available, we can use
> + // ZSTD_getErrorCode and the enum to use the public zstd API
> let (real_code, _) = 0usize.overflowing_sub(err);
> // see ZSTD_ErrorCode in https://github.com/facebook/zstd/blob/dev/lib/zstd_errors.h
> real_code == 70 // ZSTD_error_dstSize_tooSmall
> --
> 2.39.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel