From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id E439C1FF15E
for <inbox@lore.proxmox.com>; Fri, 23 Aug 2024 13:45:22 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 16E93ECE6;
Fri, 23 Aug 2024 13:45:46 +0200 (CEST)
Date: Fri, 23 Aug 2024 13:45:12 +0200
From: Christoph Heiss <c.heiss@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Message-ID: <2pkp6viou65vvk3yo7ro534ly2dkb7wgq6gta645b2ffbtf5pu@3clua67wj2rh>
References: <20240816111648.483368-1-c.heiss@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20240816111648.483368-1-c.heiss@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.033 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [pam.rs, mod.rs, ldap.rs, domains.rs, openid.rs, domain.rs,
proxmox-backup-api.rs, lib.rs, pbs.rs, proxmox.com, ad.rs]
Subject: Re: [pbs-devel] [PATCH proxmox-backup/pwt v3 00/14] fix #5379:
introduce default auth realm option
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
v4 out: https://lists.proxmox.com/pipermail/pbs-devel/2024-August/010673.html
On Fri, Aug 16, 2024 at 01:16:32PM GMT, Christoph Heiss wrote:
> Fixes #5379 [0].
>
> First, it adds an updatable `default` field to all existing editable
> realms. Then it converts the PAM and PBS built-in realms to proper
> realms, instead of being hard-coded in-between somewhere.
> In turns this enables editing of these realms, allowing setting whether
> these realms should be the default for login or not.
>
> For proxmox-widget-toolkit, the first three patches could in principal
> be applied on their own. The others depend on the API changes as
> introduced in the proxmox-backup part.
>
> W.r.t. the inconsistency as discovered/discussed in [1], the (current)
> behaviour is not changed in this series. Since both PVE and PBS use the
> same realm login dialog from proxmox-widget-toolkit, I'd rather fix it
> separately -- to avoid blocking this series on a completely separate
> issue, which might still need some discussing.
>
> W.r.t. to applying, proxmox-backup will need a bump of
> proxmox-widget-toolkit afterwards.
>
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5379
> [1] https://lists.proxmox.com/pipermail/pbs-devel/2024-August/010429.html
>
> History
> =======
>
> v2: https://lists.proxmox.com/pipermail/pbs-devel/2024-August/010521.html
> v1: https://lists.proxmox.com/pipermail/pbs-devel/2024-July/010250.html
>
> Changes v2 -> v3:
> * rebased on latest master
> * fixed unsetting the `default` property by making it deletable
> * unset previous default realm when creating a new realm with
> `default` set
>
> Changes v1 -> v2:
> * rebased on latest master
> * trivial fixes as suggested by Lukas
> * add documentation to unset_default_realm()
>
> Diffstat
> ========
>
> proxmox-widget-toolkit:
>
> Christoph Heiss (6):
> window: AuthEditBase: include more information in thrown errors
> panel: AuthView: make `useTypeInUrl` property per-realm
> window: add panel for editing simple, built-in realms
> schema: make PAM realm editable using new AuthSimple panel
> fix #5379: panel: AuthView: add column displaying whether the realm is
> default
> fix #5379: window: AuthEdit{LDAP,OpenId}: add 'Default realm' checkbox
>
> src/Makefile | 1 +
> src/Schema.js | 7 +++++-
> src/panel/AuthView.js | 13 +++++++++---
> src/window/AuthEditBase.js | 8 +++----
> src/window/AuthEditLDAP.js | 14 +++++++++++-
> src/window/AuthEditOpenId.js | 13 ++++++++++++
> src/window/AuthEditSimple.js | 41 ++++++++++++++++++++++++++++++++++++
> 7 files changed, 88 insertions(+), 9 deletions(-)
> create mode 100644 src/window/AuthEditSimple.js
>
> proxmox-backup:
>
> Christoph Heiss (8):
> fix #5379: api-types: add `default` field to all realm types
> fix #5379: api2: access: set default realm accordingly on individual
> update
> api-types: introduce proper types for PAM and PBS realms
> config: use new dedicated PAM and PBS realm types
> api2: access: add update support for built-in PAM realm
> api2: access: add update support for built-in PBS realm
> www: AccessControl: make `useTypeInUrl` property per-realm
> www: utils: make built-in pbs realm editable using new AuthSimplePanel
>
> pbs-api-types/src/ad.rs | 7 ++
> pbs-api-types/src/ldap.rs | 7 ++
> pbs-api-types/src/lib.rs | 97 ++++++++++++++++++++++-
> pbs-api-types/src/openid.rs | 7 ++
> pbs-config/src/domains.rs | 36 ++++++++-
> src/api2/access/domain.rs | 13 ----
> src/api2/config/access/ad.rs | 16 ++++
> src/api2/config/access/ldap.rs | 16 ++++
> src/api2/config/access/mod.rs | 4 +
> src/api2/config/access/openid.rs | 16 ++++
> src/api2/config/access/pam.rs | 130 +++++++++++++++++++++++++++++++
> src/api2/config/access/pbs.rs | 130 +++++++++++++++++++++++++++++++
> src/bin/proxmox-backup-api.rs | 1 +
> src/config/mod.rs | 25 ++++++
> www/Utils.js | 4 +-
> www/panel/AccessControl.js | 1 -
> 16 files changed, 492 insertions(+), 18 deletions(-)
> create mode 100644 src/api2/config/access/pam.rs
> create mode 100644 src/api2/config/access/pbs.rs
>
> --
> 2.45.1
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel