From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup 1/2] client: pxar: perform match pattern check only once
Date: Tue, 12 Nov 2024 21:25:31 +0100 [thread overview]
Message-ID: <2f517888-16a8-4006-8417-ccc124bd04cb@proxmox.com> (raw)
In-Reply-To: <20240926123437.192228-1-c.ebner@proxmox.com>
Am 26.09.24 um 14:34 schrieb Christian Ebner:
> While traversing the filesystem tree, `generate_directory_file_list`
> generates the list of entries to include for each directory level,
> already matching the entry against the given list of match patterns.
>
> Since this already excludes entries which should not be included in
> the archive, the same check in the `add_entry` call is redundant,
> as it is executed for each entry which is included in the list
> generated by `generate_directory_file_list`.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> Seems to be present since commit:
> c443f58b09 ("switch to external pxar and fuse crates")
feel free to add commit references to the commit message itself.
>
> Noticed while looking at the code because an user reported an issue in
> the community forum, the issue turned out to be unrelated:
> https://forum.proxmox.com/threads/154995/
>
> pbs-client/src/pxar/create.rs | 9 ---------
> 1 file changed, 9 deletions(-)
>
>
applied series, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-12 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 12:34 [pbs-devel] " Christian Ebner
2024-09-26 12:34 ` [pbs-devel] [PATCH proxmox-backup 2/2] client: pxar: add debug output for exclude pattern matches Christian Ebner
2024-11-12 20:25 ` Thomas Lamprecht [this message]
2024-11-13 8:23 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] client: pxar: perform match pattern check only once Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f517888-16a8-4006-8417-ccc124bd04cb@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox