From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 72952B35F for ; Wed, 23 Nov 2022 16:46:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4C8AC2458A for ; Wed, 23 Nov 2022 16:46:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 23 Nov 2022 16:46:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0E28243D5B for ; Wed, 23 Nov 2022 16:46:19 +0100 (CET) Message-ID: <2e50df5c-ef57-cbd1-e59e-403cf09f3008@proxmox.com> Date: Wed, 23 Nov 2022 16:46:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Thunderbird/108.0 Content-Language: en-GB To: Proxmox Backup Server development discussion , Lukas Wagner References: <20221028100143.9035-1-l.wagner@proxmox.com> <20221028100143.9035-2-l.wagner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221028100143.9035-2-l.wagner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 1/1] fix #3828: proxmox_backup_debug: Introduce `diff archive` subcommand. X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2022 15:46:21 -0000 Am 28/10/2022 um 12:01 schrieb Lukas Wagner: > This new subcommand compares a pxar archive in two different > snapshots and prints a list of added/modified/deleted file > entries. for future patches please avoid the use of folder or generally file names in the subject, "proxmox backup" is also a bit redundant if it's in the proxmox-backup repo already anyway. Here I'd have favored: fix #3828: debug cli: Introduce `diff archive` subcommand or maybe even: fix #3828: debug cli: add `diff archive` to compare pxar from snapshots really no biggie, but I'm calling these things out because I frequently do releases and assemble changelogs and need to churn through dozens of commits in a timely manner to extract the for user relevant stuff, and often it's great when I just grasp the whole change from the subject only, even when it was a month ago or I did not followed its development at all, and maybe even can copy it 1:1 to the debian/changelog.