From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <f.schauer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 59787BA81D
 for <pbs-devel@lists.proxmox.com>; Thu, 14 Dec 2023 15:50:51 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 399FB18C1D
 for <pbs-devel@lists.proxmox.com>; Thu, 14 Dec 2023 15:50:21 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pbs-devel@lists.proxmox.com>; Thu, 14 Dec 2023 15:50:20 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6271247637
 for <pbs-devel@lists.proxmox.com>; Thu, 14 Dec 2023 15:50:20 +0100 (CET)
Message-ID: <2d73c2db-5f2b-4a3f-85a9-7b7c5f7c2eed@proxmox.com>
Date: Thu, 14 Dec 2023 15:50:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Lukas Wagner <l.wagner@proxmox.com>,
 Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>,
 Dominik Csapak <d.csapak@proxmox.com>
References: <20231123130652.416129-1-f.schauer@proxmox.com>
 <20231123130652.416129-2-f.schauer@proxmox.com>
 <0f719e51-3407-4923-bd22-502efb4bca4d@proxmox.com>
 <9efec590-7ab0-4108-b321-896f069f7929@proxmox.com>
From: Filip Schauer <f.schauer@proxmox.com>
In-Reply-To: <9efec590-7ab0-4108-b321-896f069f7929@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.152 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pbs-devel] [PATCH v2 proxmox 1/1] fix #4995: compression:
 Include symlinks in zip file restore
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 14 Dec 2023 14:50:51 -0000

Patch v3 available:

https://lists.proxmox.com/pipermail/pbs-devel/2023-December/007538.html

On 24/11/2023 12:03, Lukas Wagner wrote:
> On 11/24/23 08:56, Dominik Csapak wrote:
>> * if you want to go the extra mile, i guess this would be a good time 
>> to add tests
>>    that create a new zip from test data, to see if they don't break 
>> with your changes
>>
>
> I agree!
>
> I think writing tests for changes should be the default and not be 
> considered as 'the extra mile' - especially considering that it should 
> be relatively easy to write tests for this crate (no weird
> dependencies, no need to run as a certain user, etc.)
>