From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8FE78C04B7 for ; Wed, 10 Jan 2024 16:10:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 712D9365FB for ; Wed, 10 Jan 2024 16:10:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 10 Jan 2024 16:10:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A174A490A6 for ; Wed, 10 Jan 2024 16:10:40 +0100 (CET) Message-ID: <2ce042b0-4e90-4366-925f-7bbeba542809@proxmox.com> Date: Wed, 10 Jan 2024 16:10:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20231211085902.20747-1-g.goller@proxmox.com> <20231211085902.20747-3-g.goller@proxmox.com> <7319fa0e-46e9-4c9b-bcdf-6bc43876d61e@proxmox.com> Content-Language: en-US From: Gabriel Goller In-Reply-To: <7319fa0e-46e9-4c9b-bcdf-6bc43876d61e@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.142 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 2/2] status: use Option on avail/used datastore attrs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2024 15:10:41 -0000 On 14-12-2023 08:55, Thomas Lamprecht wrote: > Talked a bit with Dietmar off-list and checked this out a bit closer, having > to check each property separately seems like slightly annoying extra work we > might be able to avoid while not loosing anything. > > I.e., what about keeping this as is and instead add a new usage property that > is an option of a struct with all three values as u64? > > We get this info from file-system level, so if we cannot get all at once it'd > be rather wrong anyway (from both our access control system and how we gather > those data from the kernel), so I think this is an all or nothing. > > We could then can mark the other three i64 properties as deprecated and remove > them with the next major version, thus having a clean compatibility cut and a > easier to use API. It looks like this series has been applied already, was there any off-list discussion? Do we still need the backwards compat (and above suggested changes) here? If yes, should I submit a new patch and base it off master, or submit a new version?