From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id A22DB62C4E for ; Thu, 1 Oct 2020 12:39:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id 843442046C for ; Thu, 1 Oct 2020 12:39:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id B44502045F for ; Thu, 1 Oct 2020 12:39:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id 7C20A45B80 for ; Thu, 1 Oct 2020 12:39:27 +0200 (CEST) To: pbs-devel@lists.proxmox.com References: <20200925084330.75484-1-h.laimer@proxmox.com> From: Dominik Csapak Message-ID: <2cc99393-2d2e-e702-f90a-747caef21751@proxmox.com> Date: Thu, 1 Oct 2020 12:39:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20200925084330.75484-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.547 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, proxmox-backup-proxy.rs, verify.rs, mod.rs, admin.rs, config.rs] Subject: Re: [pbs-devel] [PATCH v1 proxmox-backup 00/14] add job based verify scheduling X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2020 10:39:28 -0000 Some high level comments: * patches need some work on rebase, since there were some code changes * we sadly cannot simply remove the 'verify-schedule' from the datastore configs, as we already have packages out there that support it and it breaks all datastore config parsing we could fix that either by - leaving the schedule in place and 'magically' show it as a verifyjob - have some script that runs in postinst that rewrites the verify schedules as jobs - maybe some other method? * it would be very nice to see which backups were considered for verification, but skipped by its verify status, else the user clicks on verification and only gets: Ok but with no progress or indication what actually happened * for now i think it's okay to add a separate panel, though thomas would prefer to somehow merge the syncjob/verifyjob (and maybe also garbage_collection/prune) into a single "Job/Schedule" overview the patches itself look mostly ok though and work as expected (after correctly rebasing) i'll also write some comments to the patches directly On 9/25/20 10:43 AM, Hannes Laimer wrote: > Replaces the first implementation of scheduled verification with a new > job-based version with additional options that may be specified through > the web ui. > > Options available for verification jobs: > * schedule when to run the job > * set datastore on which the job should run > * set a number of days after which a verification becomes "outdated" > empty => verifications are valid forever > * specify if already successfuly verified snapshots should be verified > again even if they're not outdated(failed ones will always be done) > > > Hannes Laimer (14): > add two new schemas for verify jobs > add verify job config > api2: add verify job config endpoint > add do_verification_job function to verify.rs > api2: add verify job admin endpoint > add scheduling for verify jobs > set a diffrent worker_type based on what is going to be > verified(snapshot,group,ds) > ui: add verify job view > ui: add verify job edit window > ui: add task descriptions for the different types of > verify(job,snapshot,group,ds) > remove verify_schedule field from DatastoreConfig > remove verify_schedule field from datastore config endpoint > remove verify-schedule field from DataStoreEdit and DataStoreConfig > remove old verification scheduling from proxmox-backup-proxy.rs > > src/api2/admin.rs | 4 +- > src/api2/admin/datastore.rs | 5 +- > src/api2/admin/verify.rs | 107 +++++++++++++ > src/api2/config.rs | 2 + > src/api2/config/datastore.rs | 13 -- > src/api2/config/verify.rs | 272 +++++++++++++++++++++++++++++++ > src/api2/types/mod.rs | 10 ++ > src/backup/verify.rs | 91 ++++++++++- > src/bin/proxmox-backup-proxy.rs | 103 +++++------- > src/config.rs | 1 + > src/config/datastore.rs | 6 - > src/config/verify.rs | 186 ++++++++++++++++++++++ > www/Makefile | 2 + > www/NavigationTree.js | 6 + > www/Utils.js | 7 +- > www/config/DataStoreConfig.js | 5 +- > www/config/VerifyView.js | 273 ++++++++++++++++++++++++++++++++ > www/window/DataStoreEdit.js | 9 -- > www/window/VerifyJobEdit.js | 89 +++++++++++ > 19 files changed, 1089 insertions(+), 102 deletions(-) > create mode 100644 src/api2/admin/verify.rs > create mode 100644 src/api2/config/verify.rs > create mode 100644 src/config/verify.rs > create mode 100644 www/config/VerifyView.js > create mode 100644 www/window/VerifyJobEdit.js >