From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EA832904B for ; Fri, 23 Jun 2023 13:40:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CBEB933D80 for ; Fri, 23 Jun 2023 13:40:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 23 Jun 2023 13:40:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0EE3742FAC for ; Fri, 23 Jun 2023 13:40:26 +0200 (CEST) Message-ID: <2bb15087-8522-9290-23ac-825f7eeaac23@proxmox.com> Date: Fri, 23 Jun 2023 13:40:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Max Carrara References: <20230622091526.812422-1-m.carrara@proxmox.com> From: Lukas Wagner In-Reply-To: <20230622091526.812422-1-m.carrara@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.098 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.09 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lib.rs, rest.rs, connection.rs, proxmox-backup-proxy.rs] Subject: Re: [pbs-devel] [PATCH proxmox, proxmox-backup 0/3] Add support for HTTP to HTTPS redirection X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2023 11:40:57 -0000 Hello, tested this on the current master branch. Navigated to `http://:8007`, redirect to `https://:8007` works as expected. Code LGTM. Consider this: Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner On 6/22/23 11:15, Max Carrara wrote: > This patch series adds support for redirecting HTTP requests to HTTPS. This is > done by peeking into the incoming TCP stream's buffer in order to check whether > the client initiates a TLS handshake or not. > > Secure and insecure connections are then sent along separate channels, allowing > them to be handled by different `hyper::Server`s (if so desired). > > Finally, `proxmox-backup-proxy` is adapted correspondingly, making it a little > more convenient to access PBS via its web interface. > > proxmox: > > Max Carrara (2): > rest-server: Add `BiAcceptBuilder` > rest-server: Add `Redirector` > > proxmox-rest-server/src/connection.rs | 327 ++++++++++++++++++++++++++ > proxmox-rest-server/src/lib.rs | 2 +- > proxmox-rest-server/src/rest.rs | 76 ++++++ > 3 files changed, 404 insertions(+), 1 deletion(-) > > > proxmox-backup: > > Max Carrara (1): > proxy: redirect HTTP requests to HTTPS > > src/bin/proxmox-backup-proxy.rs | 45 ++++++++++++++++++++++++++++----- > 1 file changed, 38 insertions(+), 7 deletions(-) > -- - Lukas