From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EA3E09E52C for ; Mon, 27 Nov 2023 14:29:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BF38B7FA6 for ; Mon, 27 Nov 2023 14:28:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 27 Nov 2023 14:28:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EC41044B52 for ; Mon, 27 Nov 2023 14:28:32 +0100 (CET) Message-ID: <2b073619-730b-4e39-affc-45cbc624ef7c@proxmox.com> Date: Mon, 27 Nov 2023 14:28:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Wolfgang Bumiller Cc: pbs-devel@lists.proxmox.com References: <20231127105238.99947-1-g.goller@proxmox.com> <20231127105238.99947-3-g.goller@proxmox.com> From: Gabriel Goller In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.199 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH v4 proxmox-backup 2/3] node: status: added bootmode X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2023 13:29:04 -0000 Thanks for the review! On 11/27/23 14:10, Wolfgang Bumiller wrote: > On Mon, Nov 27, 2023 at 11:52:37AM +0100, Gabriel Goller wrote: >> + >> +#[api] >> +#[derive(Serialize, Deserialize, Default)] > And Clone + Copy Agree >> +#[serde(rename_all = "kebab-case")] >> +/// The possible BootModes >> +pub enum BootMode { >> + /// The BootMode is EFI/UEFI >> + Efi, >> + /// The BootMode is Legacy BIOS >> + #[default] > ^ do we *need* Default on this type? And why is Bios the default? Removed it. Was enabled on the `NodeStatus` struct and cascaded down, but afaik we can remove it on the `NodeStatus` struct as well and get rid of it. > >> + LegacyBios, >> +} >> + >> +#[api] >> +#[derive(Serialize, Deserialize, Default)] > And Clone yep >> +fn boot_mode_to_info(bm: boot_mode::BootModeInformation) -> BootModeInformation { > I'd prefer the match to be a single level by doing > > use boot_mode::{BootModeIntofmation::*, SecureBoot}; > use pbs_api_types::BootMode; > match bm { > Efi(SecureBoot::Enabled) => BootModeInformation { > ... > mode: BootMode::Efi, > secureboot: true, > }, > Efi(SecureBoot::Disabled) => BootModeInformation { > ... > mode: BootMode::Efi, > secureboot: false, > }, > Bios => BootModeInformation { > ... > mode: BootMode::LegacyBios, > secureboot: false, > }, > } > > IMO that's easier to follow. Good point!