From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CC7011FF38A for ; Fri, 28 Jun 2024 11:25:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 74E3934544; Fri, 28 Jun 2024 11:25:43 +0200 (CEST) Message-ID: <2b069a9b-93ff-4d3d-bacc-81fb852f406d@proxmox.com> Date: Fri, 28 Jun 2024 11:25:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Gabriel Goller References: <20240626131120.336868-1-g.goller@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner In-Reply-To: <20240626131120.336868-1-g.goller@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} v6 0/4] proxmox-log introduction X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 2024-06-26 15:10, Gabriel Goller wrote: > Removed the task_log! (and friends task_warn!, task_debug!, etc.) macro > and introduced the `tracing` crate. We now initiate the tracing crate > using two layer, which are logging to the syslog and the tasklog. > It uses the `tracing-journald` crate and the original `FileLogger`. > > To write to the task logs from the worker threads and tasks, we now > have a task_local logger (and warning counter), which > will get instantiated when a task/thread is created. This means that > when we call `info!` or any other `tracing` log macros, it will get > the file_logger from TLS and write to the file. > > v6, thanks @Lukas: > - rebase > - reorder imports, inline variables > - introduce `tracing-journald` and throw out `syslog` > - split single layer into two, one for syslog and for tasklog > > > > Summary over all repositories: > 46 files changed, 809 insertions(+), 1114 deletions(-) > LGTM now. Could you post a cargo fmt'd v7? There are some whitespace errors (trailing spaces) and some minor formatting issues, nothing major. Feel free to already augment the following trailers to your v7 commits: Reviewed-by: Lukas Wagner Tested-by: Lukas Wagner -- - Lukas _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel