From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 381E56CAF9 for ; Fri, 24 Sep 2021 11:11:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2EC442FFD4 for ; Fri, 24 Sep 2021 11:10:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BC8142FFC6 for ; Fri, 24 Sep 2021 11:10:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 89B564323D for ; Fri, 24 Sep 2021 11:10:45 +0200 (CEST) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210923134732.1768609-1-d.csapak@proxmox.com> From: Dietmar Maurer Message-ID: <2abc2034-8c78-b2f2-d6c5-12391ccc3bfa@proxmox.com> Date: Fri, 24 Sep 2021 11:10:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210923134732.1768609-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.574 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [upid.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup] upid: remove arbitrary 128 max length for UPID X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Sep 2021 09:11:16 -0000 applied to proxmox crate (upid is now in proxmox crate) On 9/23/21 3:47 PM, Dominik Csapak wrote: > we can easily go beyond that when having long datastore/remote names > also because we do 'systemd-encode' them, which means that every special > char takes up 4 bytes (e.g. '-' => '\x2d') > > while we could just increase the lenght to say 256 or 512, i do not > really see the benefit to limit this at all, since users cannot create > tasks with arbitrary names, and all other fields are generated from > other valid types (username, datastore, remote, etc.) > > Signed-off-by: Dominik Csapak > --- > pbs-api-types/src/upid.rs | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/pbs-api-types/src/upid.rs b/pbs-api-types/src/upid.rs > index ba23a646..3094be2d 100644 > --- a/pbs-api-types/src/upid.rs > +++ b/pbs-api-types/src/upid.rs > @@ -58,7 +58,6 @@ pub const PROXMOX_UPID_FORMAT: ApiStringFormat = > > pub const UPID_SCHEMA: Schema = StringSchema::new("Unique Process/Task Identifier") > .min_length("UPID:N:12345678:12345678:12345678:::".len()) > - .max_length(128) // arbitrary > .format(&PROXMOX_UPID_FORMAT) > .schema(); >