From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ECE2467BCA for ; Tue, 10 Nov 2020 14:14:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E430421A99 for ; Tue, 10 Nov 2020 14:14:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8318021A85 for ; Tue, 10 Nov 2020 14:14:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4675446046 for ; Tue, 10 Nov 2020 14:14:29 +0100 (CET) To: Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20201110125250.3750178-1-f.gruenbichler@proxmox.com> From: Thomas Lamprecht Message-ID: <2a04dde1-b42e-21ed-ce4e-2e4b64d69778@proxmox.com> Date: Tue, 10 Nov 2020 14:14:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201110125250.3750178-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.102 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, verify.rs] Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 1/2] verify: log/warn on invalid owner X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2020 13:14:30 -0000 On 10.11.20 13:52, Fabian Gr=C3=BCnbichler wrote: > in order to trigger a notification/make the problem more visible than > just in syslog. >=20 > Signed-off-by: Fabian Gr=C3=BCnbichler > --- >=20 > Notes: > not filtering in case we don't have an explicit owner passed in to = keep > backwards compat - we could also skip verification for them even in= the > privileged case.. ? >=20 > -w --patience makes this easier to read >=20 > src/api2/admin/datastore.rs | 2 +- > src/backup/verify.rs | 42 ++++++++++++++++++++++---------------= > 2 files changed, 26 insertions(+), 18 deletions(-) >=20 > applied both patches, thanks!