From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 671E6759AA for ; Tue, 13 Jul 2021 12:08:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5E5551FB91 for ; Tue, 13 Jul 2021 12:08:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4C1271FB81 for ; Tue, 13 Jul 2021 12:08:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2271C40D3B for ; Tue, 13 Jul 2021 12:08:19 +0200 (CEST) To: Proxmox Backup Server development discussion , Stefan Reiter References: <20210713092321.597180-1-s.reiter@proxmox.com> From: Dietmar Maurer Message-ID: <297db9c2-0644-2926-6cb3-512d33d5a92a@proxmox.com> Date: Tue, 13 Jul 2021 12:08:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210713092321.597180-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.914 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH v2 proxmox-backup 1/2] file-restore: increase lock timeout on QEMU map X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 10:08:20 -0000 applied On 7/13/21 11:23 AM, Stefan Reiter wrote: > This lock is held during VM startup, so that multiple calls will not > start VMs twice. But this means that the timeout needs to incorporate > the time it might take a VM to boot, so increase it quite a bit. > > This could previously lead to "interrupted system call" errors when > accessing backups with many disks. > > Signed-off-by: Stefan Reiter > --- > > v2: unchanged > > src/bin/proxmox_file_restore/block_driver_qemu.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/bin/proxmox_file_restore/block_driver_qemu.rs b/src/bin/proxmox_file_restore/block_driver_qemu.rs > index 24f62796..46d91198 100644 > --- a/src/bin/proxmox_file_restore/block_driver_qemu.rs > +++ b/src/bin/proxmox_file_restore/block_driver_qemu.rs > @@ -50,7 +50,7 @@ impl VMStateMap { > /// Acquire a lock on the state map and retrieve a deserialized version > fn load() -> Result { > let mut file = Self::open_file_raw(true)?; > - lock_file(&mut file, true, Some(std::time::Duration::from_secs(5)))?; > + lock_file(&mut file, true, Some(std::time::Duration::from_secs(120)))?; > let map = serde_json::from_reader(&file).unwrap_or_default(); > Ok(Self { map, file }) > }