From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5849A75624 for ; Mon, 12 Jul 2021 19:10:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4DB0B190DF for ; Mon, 12 Jul 2021 19:10:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3D98D190CD for ; Mon, 12 Jul 2021 19:10:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0438641022 for ; Mon, 12 Jul 2021 19:10:02 +0200 (CEST) Message-ID: <29128580-dfcc-2306-d68d-470fa64dbe2e@proxmox.com> Date: Mon, 12 Jul 2021 19:09:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Stefan Reiter References: <20210712163047.3119673-1-s.reiter@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210712163047.3119673-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.464 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup] auth: 'crypt' is not thread safe X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jul 2021 17:10:03 -0000 On 12.07.21 18:30, Stefan Reiter wrote: > According to crypt(3): > "crypt places its result in a static storage area, which will be > overwritten by subsequent calls to crypt. It is not safe to call crypt > from multiple threads simultaneously." > > This means that multiple login calls as a PBS-realm user can collide and > produce intermittent authentication failures. A visible case is for > file-restore, where VMs with many disks lead to just as many auth-calls > at the same time, as the GUI tries to expand each tree element on load. > > Instead, use the thread-safe variant 'crypt_r', which places the result > into a pre-allocated buffer of type 'crypt_data'. The C struct is laid > out according to 'lib/crypt.h.in' and the man page mentioned above. > > Use the opportunity and make both arguments to the rust 'crypt' function > take a &[u8]. > > Signed-off-by: Stefan Reiter > --- > > Easier solution would of course be to just wrap the call in a Mutex<()> or > similar, but that comes at the cost of locking... > > src/auth.rs | 57 +++++++++++++++++++++++++++++++++++++++-------------- > 1 file changed, 42 insertions(+), 15 deletions(-) > > applied, thanks!