From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5663C95C8F for <pbs-devel@lists.proxmox.com>; Fri, 20 Jan 2023 08:48:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 389D75511 for <pbs-devel@lists.proxmox.com>; Fri, 20 Jan 2023 08:48:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Fri, 20 Jan 2023 08:48:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CBACD454E2 for <pbs-devel@lists.proxmox.com>; Fri, 20 Jan 2023 08:48:24 +0100 (CET) Message-ID: <283ad315-6d1b-d3a8-225f-f8628d00187f@proxmox.com> Date: Fri, 20 Jan 2023 08:48:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Content-Language: en-GB To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Lukas Wagner <l.wagner@proxmox.com> References: <20230119155232.802404-1-l.wagner@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20230119155232.802404-1-l.wagner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [network.rs, dns.rs, remote.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup] api: serde-rename deleteable properties to kebab-case X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 20 Jan 2023 07:48:56 -0000 Am 19/01/2023 um 16:52 schrieb Lukas Wagner: > In former commit, the enum members were renamed to be CamelCase, in > accordance with the usual Rust style guide. However, this broke the > GUI in some places due to failing JSON property deserialization. > To fix this, some serde(rename = "kebab-case") directives were added. > > Some properties were also serde-renamed to snake_case, otherwise > it would have been necessary to also modify proxmox-widget-toolkit > as well as PVE source code. This can follow in a later commit if so > desired. > > Fixes: a2055c38 fix non-camel-case enums > Signed-off-by: Lukas Wagner <l.wagner@proxmox.com> > --- > src/api2/config/media_pool.rs | 1 + > src/api2/config/remote.rs | 1 + > src/api2/node/dns.rs | 1 + > src/api2/node/network.rs | 5 ++++- > 4 files changed, 7 insertions(+), 1 deletion(-) > > applied, thanks! Wonder if we could have some sane checks for catching that; e.g., a rust test that reads a in-git saved schema and diffs it with the current one, with noting/warning newly added properties and throwing an error if existing ones change, so that the dev needs to record such changes explicitly with the patch they're modifying it, if it's a wanted change that is.