From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1555F1FF2AF for <inbox@lore.proxmox.com>; Mon, 22 Jul 2024 09:30:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 854351CFB1; Mon, 22 Jul 2024 09:31:07 +0200 (CEST) Message-ID: <27efb361-4a4f-46fd-891f-210937554f74@proxmox.com> Date: Mon, 22 Jul 2024 09:30:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Max Carrara <m.carrara@proxmox.com>, Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> References: <20240712112755.123630-1-l.wagner@proxmox.com> <20240712112755.123630-2-l.wagner@proxmox.com> <D2RXAFPMESB8.1Y55FC208MV5L@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner <l.wagner@proxmox.com> In-Reply-To: <D2RXAFPMESB8.1Y55FC208MV5L@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.007 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [pve-devel] [PATCH proxmox v2 01/12] notify: implement webhook targets X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> On 2024-07-17 17:35, Max Carrara wrote: >> + let handlebars = setup_handlebars(); >> + let body_template = self.base_64_decode(self.config.body.as_deref().unwrap_or_default())?; >> + >> + let body = handlebars >> + .render_template(&body_template, &data) >> + .map_err(|err| { >> + // TODO: Cleanup error types, they have become a bit messy. >> + // No user of the notify crate distinguish between the error types any way, so >> + // we can refactor without any issues.... >> + Error::Generic(format!("failed to render webhook body: {err}")) > > I'm curious, how would you clean up the error types in particular? > Right now, error handling is a bit messy... Some endpoints primarily use the `NotifyFailed` variant, which wraps another error, while in some places where I need a leaf error type that does not wrap any error I use the `Generic` variant, which only stores a string. I could have used the `NotifyFailed` variant here, but that one would not have allowed me to add additional context ("failed to render webhook ..."), unless wrapping another `Generic` variant... I don't have yet made any detailed plans on how to clean that up though. -- - Lukas _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel