From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9F59CAE7E for ; Wed, 28 Jun 2023 14:18:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7AA8E3EC76 for ; Wed, 28 Jun 2023 14:17:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 28 Jun 2023 14:17:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2C7FB41ADB for ; Wed, 28 Jun 2023 14:17:45 +0200 (CEST) Message-ID: <27cc8bfe-c42d-6e20-ce3c-2fb561cefd44@proxmox.com> Date: Wed, 28 Jun 2023 14:17:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Christian Ebner References: <20230628115328.77255-1-c.ebner@proxmox.com> From: Fiona Ebner In-Reply-To: <20230628115328.77255-1-c.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.006 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.103 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH v3 backup stable-2] pbs2to3: add upgrade checker binary X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jun 2023 12:18:16 -0000 Am 28.06.23 um 13:53 schrieb Christian Ebner: > Adds the pbs2to3 upgrade checker with some basic checks. > > Signed-off-by: Christian Ebner > --- Didn't give it an in-depth look, because of limited time, but: Reviewed-by: Fiona Ebner Tested-by: Fiona Ebner Potential for follow-up: After upgrade, I got WARN: a suitable kernel 'pve-kernel-6.2' is installed, but an unsuitable '6.2.9-1-pve' is booted, missing reboot?! which is a bit confusing because the booted one is a pve-kernel-6.2, just not the newest ;) > + > + fn check_repo_file( > + &mut self, > + found_suite: &mut Option<(String, String)>, > + mismatches: &mut Vec<(String, String)>, > + strange_suite: &mut bool, > + repo_file: APTRepositoryFile, > + ) -> Result<(), Error> { > + for repo in repo_file.repositories { > + if !repo.enabled || repo.types == [APTRepositoryPackageType::DebSrc] { > + continue; > + } > + for suite in &repo.suites { > + let suite = match suite.find(&['-', '/'][..]) { > + Some(n) => &suite[0..n], > + None => suite, > + }; > + > + if suite != OLD_SUITE && suite != NEW_SUITE { > + let location = repo_file.path.clone().unwrap_or_default(); > + self.output.log_notice(format!( > + "found unusual suite '{suite}', neighter old '{OLD_SUITE}' nor new \ typo: s/neighter/neither/