From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id DC7AA1FF166
	for <inbox@lore.proxmox.com>; Fri, 25 Oct 2024 12:44:37 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id ABBC01DE94;
	Fri, 25 Oct 2024 12:44:37 +0200 (CEST)
Message-ID: <27b7a014-4fa3-4489-8a13-d90df6b32e3b@proxmox.com>
Date: Fri, 25 Oct 2024 12:44:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>, Christian Ebner <c.ebner@proxmox.com>
References: <20241018084242.144010-1-c.ebner@proxmox.com>
 <20241018084242.144010-26-c.ebner@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20241018084242.144010-26-c.ebner@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.016 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH v5 proxmox-backup 25/31] ui: sync view: set
 sync direction when invoking run task via api
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

imho this and the previous patch should be squashed together,
since the previous one mentions this behaviour anyway
and does not make much sense without

On 10/18/24 10:42, Christian Ebner wrote:
> Set the correct sync direction for the task to be executed.
> Otherwise the task whit the correct id cannot be found as the config
> lookup requires the correct config type to be set, which is done
> based on the sync direction.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 4:
> - no changes
> 
> changes since version 3:
> - no changes
> 
>   www/config/SyncView.js | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/www/config/SyncView.js b/www/config/SyncView.js
> index 39e464fc5..bf0c7e8c0 100644
> --- a/www/config/SyncView.js
> +++ b/www/config/SyncView.js
> @@ -83,9 +83,14 @@ Ext.define('PBS.config.SyncJobView', {
>   	    if (selection.length < 1) return;
>   
>   	    let id = selection[0].data.id;
> +	    let params = {};
> +	    if (view.syncDirection !== undefined) {
> +		params["sync-direction"] = view.syncDirection;
> +	    }
>   	    Proxmox.Utils.API2Request({
>   		method: 'POST',
>   		url: `/admin/sync/${id}/run`,
> +		params: params,
>   		success: function(response, opt) {
>   		    Ext.create('Proxmox.window.TaskViewer', {
>   		        upid: response.result.data,



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel